search

ni / niveristand-data-sharing-framework-custom-device

NI VeriStand custom device to provide a plugin-based approach to reflecting data between applications.
MIT License
1 stars 8 forks source link

Enable Faulting on DSF Channels #66

Open bsnover opened 1 year ago

bsnover commented 1 year ago

Is your feature request related to a problem? Please describe. There could be scenarios where the lack of Faulting is very inconvenient, but I think there are workarounds. This is more of a nice to have.

Describe the solution you'd like Enable faulting on channels in the DSF. I haven't tested this, but I believe it is as simple as changing a Boolean within a single VI. image

Additional context Faulting allows someone to manually or programmatically override channel or network mappings. If I have a DSF input that gets data from an external network source, Faulting allows me to create my own data profile for that channel for testing purposes. Similarly if I have a DSF output that gets data from a local hardware input or model calculation, Faulting allows me to override that value and send any value that I would like over the network.

To me the bigger question is what is the harm in enabling this? If there isn't a good reason to disable it, it should be enabled.

rtzoeller commented 1 year ago

@bsnover thanks for filing this.

I need to review the implementation of channel faulting to confirm there will not be a performance impact to enabling this for many channels. If there is, we may need to provide a way to conditionally enable it.

If there is not a performance impact to enabling it, I agree it is reasonable to do so for all channels.