Closed csjall closed 4 years ago
Does this currently install on top of the existing custom device?
Does this currently install on top of the existing custom device?
This will currently install over the existing Embedded Data Logger Custom Device. We are re-using the same GUIDs so it should be a drop in replacement. I will work with Trim to figure out how we will stage it with VeriStand 2020 installer.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Does this currently install on top of the existing custom device?
This will currently install over the existing Embedded Data Logger Custom Device. We are re-using the same GUIDs so it should be a drop in replacement. I will work with Trim to figure out how we will stage it with VeriStand 2020 installer.
I have concerns with the post-build action automatically overwriting the custom device shipped with VeriStand when built locally, since there is no good way to repair the existing installed custom device without reinstalling all of VeriStand. We might consider disabling the post-build action for now.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
What does this Pull Request accomplish?
This moves Embedded Data Logger custom device from closed VeriStand source to open GitHub source. Note that automated tests should be added in a subsequent pull request.
Why should this Pull Request be merged?
Open source the Embedded Data Logger for easier debugging and contributing.
What testing has been done?
Ran basic sanity test on Windows and PharLap.