Mutate legacy system definition files

csjall commented 4 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Fix for #9

Why should this Pull Request be merged?

Allow users to mutate legacy embedded data logger system definition file.

What testing has been done?

Open a legacy system definition file and successfully deploy mutated configuration.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-08/12%3A30%3A31/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)

Embedded Data Logger System Explorer.lvlib--Get XML Custom Device Version.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-08/12%3A30%3A31/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Get%20XML%20Custom%20Device%20Version.vi.png)

Embedded Data Logger System Explorer.lvlib--Mutate Device Driver Path.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-08/12%3A30%3A31/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Device%20Driver%20Path.vi.png)

Embedded Data Logger System Explorer.lvlib--Mutate Log File Directory.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-08/12%3A30%3A31/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Log%20File%20Directory.vi.png)

Embedded Data Logger System Explorer.lvlib--Set Custom Device Driver.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-08/12%3A30%3A31/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Set%20Custom%20Device%20Driver.vi.png)

rtzoeller commented 4 years ago

Mutated Device Driver Path.vi doesn't have an entry for VxWorks. Is that intentional?

I believe so. I think we dropped support in either 2018 or 2019 (although if it is the latter, it'd be a little weird since the custom device builds for 2018).

buckd commented 4 years ago

I believe so. I think we dropped support in either 2018 or 2019

How ironic that the previous mutation was done in order to support VxWorks.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)

Embedded Data Logger System Explorer.lvlib--Get XML Custom Device Version.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Get%20XML%20Custom%20Device%20Version.vi.png)

Embedded Data Logger System Explorer.lvlib--Mutate Device Driver Path.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Device%20Driver%20Path.vi.png)

Embedded Data Logger System Explorer.lvlib--Mutate Log File Directory.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Log%20File%20Directory.vi.png)

Embedded Data Logger System Explorer.lvlib--Set Custom Device Driver.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Set%20Custom%20Device%20Driver.vi.png)

Embedded Data Logger Unit Tests.lvclass--Assert System Definition File Mutated.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20Unit%20Tests.lvclass--Assert%20System%20Definition%20File%20Mutated.vi.png)

Embedded Data Logger Unit Tests.lvclass--Mutate System Definition File.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20Unit%20Tests.lvclass--Mutate%20System%20Definition%20File.vi.png)

Embedded Data Logger Unit Tests.lvclass--Open System Definition.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20Unit%20Tests.lvclass--Open%20System%20Definition.vi.png)

Embedded Data Logger Unit Tests.lvclass--test Mutate Device Driver.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-10/2020-01-09/11%3A25%3A43/Embedded%20Data%20Logger%20Unit%20Tests.lvclass--test%20Mutate%20Device%20Driver.vi.png)

ni / niveristand-embedded-data-logger-custom-device