niveristand-diff-bot
commented
4 years ago Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png
Embedded Data Logger Engine.lvlib--Flush Close Archive File.vi.png
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png
Embedded Data Logger System Explorer.lvlib--Build Data Log Archive Path.vi.png
Embedded Data Logger System Explorer.lvlib--File Page.vi.png
Embedded Data Logger System Explorer.lvlib--Get Data Log File Settings.vi.png
The following VIs could not be diffed:
- C:\jenkins\workspace_data-logger-custom-device_PR-11\Source\Shared\Constants.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-11\Source\Tests\System\Assert Log File Exists.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-11\Source\Tests\System\Assert Log Folder Is Empty.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-11\Source\Tests\System\Log Command.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-11\Source\Tests\System\Log Trigger.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-11\Source\Tests\System\setUp.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-11\Source\Tests\System\test Log Archive.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-11\Source\Tests\System\test Log File.vi
debryant
buckd
What does this Pull Request accomplish?
Add support for optionally moving closed tdms files to a user specified archive directory
Why should this Pull Request be merged?
A directory of completed files can serve as a staging area for moving these to another location on the network
What testing has been done?
Ran existing auto-tests. Added a new auto test for this feature. Manually tested the system explorer changes.
Details of VI changes
Shared Constants.vi -Properties tab: Added entries for Log File Dir, Timestamp, Log Archive Dir, and Archive Files
Configuration File Page: -Added controls to the UI for Archive Files (boolean) and Archive Directory (Path)
Get Data Log File Settings.vi: -Read Archive Files and Log Archive Dir properties -Rearranged indicators on conpane to allow the Archive and Archive Log Directory to be side by side -Replace hard coded constants with globals from Shared/Constants.vi
Build Data Log Archive Path.vi: (new)
Engine File Logging Specification.ctl: -Add controls for Archive (boolean) and Archive Directory (path)
Get Data Log File Settings.vi -Read Archive Files and Log Archive Dir properties -Rearranged indicators on conpane to allow the Archive and Archive Log Directory to be side by side -Replace hard coded constants with globals from Shared/Constants.vi
Initialize Logging Data.vi -Wire Get Data Log File Settings.vi subVI's Archive and Archive Log Directory outputs into File Logging Specification cluster control
Asynchronous Logging Loop.vi: -Initialize case: If Archive, create the Archive Directory hierarchy folders -Close File: Move inner structure contents into subVI "Flush Close Archive File.vi" -Shutdown case: Replace inner structure contents with subVI "Flush Close Archive File.vi"
Flush Close Archive File.vi: (new) -Main code is from Asynchronous Logging Loop.vi Close/Shutdown cases -Added support to move the file to the Archive Directory if Archive is True
Embedded Data Loggger Engine.lvlib: -Add Flush Close Archive File.vi
Tests Assert Log File Exists.vi: (new) Assert Log File is Empty: (new)
EDL.vissdf -Add 2nd logger definition for file archive testing
Embedded Data Logger System Tests.lvclass -Add new VIs -Various connector pane/state changes to other VIs
Log Command.vi Log Trigger.vi -Add param for Embedded Data Logger File Name so can use this VI for multiple data logger file tests
setUp.vi -Delete pre-existing log directories before starting the testing
test Log Archive.vi (new)
test Log File.vi -Update to param changes made to Log Command.vi and Log Trigger.vi