File span support

[debryant]

• [x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Add file spanning support to the embedded data logger custom device such that a tdms file can optionally be closed and a new one opened after a defined time has passed or the tdms file reaches a defined size.

Why should this Pull Request be merged?

Some tests may execute over an extended period of time, which can issue in a very large tdms file when only a single file is generated to contain all of the logged data. Very large files can be unmanageable, taking longer times to load into a viewer or search for particular data sets. Allowing files to be broken into manageable chunks can increase usability and access of the tdms data.

Fixes #2

What testing has been done?

Created new unit tests for the feature and ran the full set of existing tests.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png


Embedded Data Logger Engine.lvlib--Compute if Should Span.vi.png


Embedded Data Logger Engine.lvlib--Flush Close Archive File.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log Directory Settings.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png


Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png


Embedded Data Logger Shared.lvlib--Constants.vi.png


Embedded Data Logger Shared.lvlib--Get Data Log File Span Settings.vi.png


Embedded Data Logger System Explorer.lvlib--Enable or Disable.vi.png


Embedded Data Logger System Explorer.lvlib--File Page.vi.png


Post Error.vi.png


Post Information.vi.png


The following VIs could not be diffed:

• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Duration.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Size.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Get Oldest File in Directory.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\setUp.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Span Size.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Span Time.vi

[niphilj]

@debryant , in the situation where you configure a new log file based on a time span, the time then elapses to create a new file but no data was ever written to previous log file. Do you expect that a new file will be created regardless, potentially creating a set of empty files?

Whatever the decision, to be ok with empty files, or only generate new files when the previous file is >0kb, please add a test that validates that behavior.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png


Embedded Data Logger Engine.lvlib--Compute if Should Span.vi.png


Embedded Data Logger Engine.lvlib--Flush Close Archive File.vi.png


Embedded Data Logger Engine.lvlib--Flush File Data.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log Directory Settings.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png


Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png


Embedded Data Logger Shared.lvlib--Constants.vi.png


Embedded Data Logger Shared.lvlib--Get Data Log File Span Settings.vi.png


Embedded Data Logger System Explorer.lvlib--Enable or Disable.vi.png


Embedded Data Logger System Explorer.lvlib--File Page.vi.png


Embedded Data Logger System Explorer.lvlib--Get Segment File Size Control Caption.vi.png


Post Error.vi.png


Post Information.vi.png


The following VIs could not be diffed:

• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Duration.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Size.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Get Oldest File in Directory.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\setUp.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Span Size.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Span Time.vi

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png


Embedded Data Logger Engine.lvlib--Compute if Should Span.vi.png


Embedded Data Logger Engine.lvlib--Flush Close Archive File.vi.png


Embedded Data Logger Engine.lvlib--Flush File Data.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log Directory Settings.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png


Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png


Embedded Data Logger Shared.lvlib--Constants.vi.png


Embedded Data Logger Shared.lvlib--Get Data Log File Span Settings.vi.png


Embedded Data Logger System Explorer.lvlib--Enable or Disable.vi.png


Embedded Data Logger System Explorer.lvlib--File Page.vi.png


Embedded Data Logger System Explorer.lvlib--Get Segment File Size Control Caption.vi.png


Post Error.vi.png


Post Information.vi.png


The following VIs could not be diffed:

• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Duration.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Size.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Get Oldest File in Directory.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\setUp.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Span Size.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Span Time.vi

[debryant]

Done. Thanks for catching these :)

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png


Embedded Data Logger Engine.lvlib--Compute if Should Span.vi.png


Embedded Data Logger Engine.lvlib--Flush Close Archive File.vi.png


Embedded Data Logger Engine.lvlib--Flush File Data.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log Directory Settings.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png


Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png


Embedded Data Logger Shared.lvlib--Constants.vi.png


Embedded Data Logger Shared.lvlib--Get Data Log File Span Settings.vi.png


Embedded Data Logger System Explorer.lvlib--Enable or Disable.vi.png


Embedded Data Logger System Explorer.lvlib--File Page.vi.png


Embedded Data Logger System Explorer.lvlib--Get Segment File Size Control Caption.vi.png


The following VIs could not be diffed:

• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Duration.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Is Valid.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Assert Log File Size.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\Get Oldest File in Directory.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\setUp.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Archive.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log File.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Span Size.vi
• C:\jenkins\workspace_data-logger-custom-device_PR-13\Source\Tests\System\test Log Span Time.vi