niveristand-diff-bot
commented
4 years ago Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
testExample 1.vi.png
The following VIs could not be diffed:
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Common System Tests\setUp.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Common System Tests\tearDown.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Common System Tests\test Initial Channel Values.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Assert Log File Duration.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Assert Log File Exists.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Assert Log File Is Valid.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Assert Log File Size.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Assert Log Folder Is Empty.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Get Oldest File in Directory.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Get System Time.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Log Command.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\Log Trigger.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\setUp.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\tearDown.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\test Log Archive.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\test Log File.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\test Log Span Size.vi
- C:\jenkins\workspace_data-logger-custom-device_PR-15\Source\Tests\System\Windows System Tests\test Log Span Time.vi
What does this Pull Request accomplish?
Move tests which are not written correctly for RT targets to a separate test case. These tests now only run on Windows.
Split the test system definition into a system definition per-test, since they don't need to be coupled.
Why should this Pull Request be merged?
This should stop tests from being run on targets where they will always fail. This is not a true regression in test coverage.
What testing has been done?
Ran the tests on Windows locally.