ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 10 forks source link

Save default property values for archiving and spanning to system definition #18

Closed Sarci1 closed 4 years ago

Sarci1 commented 4 years ago

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

Changed New Log File Configuration.vi to save default archiving and spanning properties when first adding a Log File to the system definition. Updated the File Page.vi to change some Value changes to Value (Signaling) to trigger the event structure appropriately.

Why should this Pull Request be merged?

Not merging this means that default properties like the archive directory and spanning size may not be saved to the system definition before deployment unless the user makes a change. This results in erroneous behavior.

What testing has been done?

Manual testing on my side to view the sys def xml updates appropriately at the correct times.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--File Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-18/2020-03-18/15%3A39%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--File%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--New Log File Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-18/2020-03-18/15%3A39%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--New%20Log%20File%20Configuration.vi.png)
Sarci1 commented 4 years ago
  • [ ] There is now a problem with changing the default values for segmenting. If I use time span for segmenting and change the default value from 60, when I save and reopen, the value has reverted back to 60. Also, checking the sysdef XML, shows the default is what was saved. Same thing with size spanning.

I removed the Value (Signaling) for the Segmenting option upon page initialization. This was resetting the value incorrectly.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--File Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-18/2020-03-19/09%3A39%3A38/Embedded%20Data%20Logger%20System%20Explorer.lvlib--File%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--New Log File Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/VeriStand/ni/niveristand-embedded-data-logger-custom-device/PR-18/2020-03-19/09%3A39%3A38/Embedded%20Data%20Logger%20System%20Explorer.lvlib--New%20Log%20File%20Configuration.vi.png)