ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 9 forks source link

File and time segmenting values can be set to zero, breaking the custom device #23

Closed rtzoeller closed 4 years ago

rtzoeller commented 4 years ago

Describe the bug The UI allows values which will break the custom device to be entered. You should never segment at zero seconds or zero MB.

To Reproduce Configure the custom device to log to a file, segmenting based on file size with the size set to zero. Map ~20 channels to the log file and deploy. When logging is enabled, observe that the FIFO utilization immediately shoots up towards the 100%.

Expected behavior These values should have a reasonable, non-zero minimum. For size, that is probably 1MB. For time duration, that may be a higher number, since segmenting every second likely doesn't make much sense (although we could allow it).

Screenshots image

Desktop (please complete the following information): Tested with on a PXI NI Linux RT target.

Additional context