search

ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 10 forks source link

Update files and channel groups tables when removing items #29

Closed rtzoeller closed 3 years ago

rtzoeller commented 3 years ago

What does this Pull Request accomplish?

Fixes AzDO 1095801.

Why should this Pull Request be merged?

The files and channel groups tables are not refreshing properly when removing items, and this can lead to a deadlock if an item is removed twice.

What testing has been done?

Hand testing of the UI.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-29/2020-08-11/10%3A19%3A52/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Main Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-29/2020-08-11/10%3A19%3A52/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Main%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Files Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-29/2020-08-11/10%3A19%3A52/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Files%20Table.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Groups Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-29/2020-08-11/10%3A19%3A52/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Groups%20Table.vi.png)
rtzoeller commented 3 years ago

@niphilj I believe I have applied this change - can you confirm the new behavior meets your expectations?

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-29/2020-08-12/14%3A26%3A58/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Main Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-29/2020-08-12/14%3A26%3A58/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Main%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Files Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-29/2020-08-12/14%3A26%3A58/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Files%20Table.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Groups Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-29/2020-08-12/14%3A26%3A58/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Groups%20Table.vi.png)