search

ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 10 forks source link

Update the status group glyph and the file status glyph #30

Closed debryant closed 3 years ago

debryant commented 3 years ago

What does this Pull Request accomplish?

Update the status group glyph and the file status glyph to match UX recommendations for the custom devices. Side effect: updated the Commands group page to use the same VI as the Status group page so these match.

Glyph Before and After

Why should this Pull Request be merged?

This change makes the UI consistent with other new custom devices added after UX provided guidance for the status group folder.

What testing has been done?

Built and ran the system explorer configuration library. See attached image for before and after shots of the Status folder. Built the engine code. Verified that a system definition file with an embedded data logger added can be deployed. Apart from 2 guids being newly added to the shared Constants.vi, all changes are in the System Explorer code.

Other

Note that the only change to the lvlib is the addition of the new Group Page.vi.

rtzoeller commented 3 years ago

It looks like existing instances of the custom device are not being mutated to have the new GUID for the status section. This results in them using the new icon for File Status, but the old icon for Status.

image

I'm not sure this functionally impacts anything, but we would want the icons to be applied consistently. You'll need to bump the version in Custom Device Embedded Data Logger.xml in order to run mutation in ActionVIOnLoad.vi. You will need to find the channels/sections with the old GUIDs and update them to use the new GUIDs.

I don't love the version used in the custom device's XML (it's currently 2020.0.0.0, but we really only use it for mutation and not the release version as is implied), but I think bumping the patch version makes sense given the existing format of the version string. E.g. 2020.0.1.0. Thoughts?

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-30/2020-09-10/08%3A38%3A45/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--New Log File Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-30/2020-09-10/08%3A38%3A45/Embedded%20Data%20Logger%20System%20Explorer.lvlib--New%20Log%20File%20Configuration.vi.png)

The following VIs could not be diffed:

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-30/2020-09-10/12%3A43%3A14/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-30/2020-09-10/12%3A43%3A14/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Status Glyph.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-30/2020-09-10/12%3A43%3A14/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Status%20Glyph.vi.png)
Embedded Data Logger System Explorer.lvlib--New Log File Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-30/2020-09-10/12%3A43%3A14/Embedded%20Data%20Logger%20System%20Explorer.lvlib--New%20Log%20File%20Configuration.vi.png)

The following VIs could not be diffed: