ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 10 forks source link

verify if directory root paths are suitable for the target #31

Closed debryant closed 3 years ago

debryant commented 3 years ago

What does this Pull Request accomplish?

Evaluate the current path value and if needed post/clear a warning to the System Explorer Errors notifying the user that their path may not be valid. The paths are checked when the custom device is saved (catches these cases when the target OS is changed), when an embedded data logger file page is loaded, and when a change is made to a file path.

image

Why should this Pull Request be merged?

Helps users identify errors to paths during edit time.

What testing has been done?

Built and manually tested the edit-time feature in system explorer, The change has no impact of the engine code.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--ActionVIOnSave (File).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-31/2020-09-18/14%3A37%3A00/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnSave%20(File).vi.png)
Embedded Data Logger System Explorer.lvlib--Check and Toggle Error.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-31/2020-09-18/14%3A37%3A00/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Check%20and%20Toggle%20Error.vi.png)
Embedded Data Logger System Explorer.lvlib--File Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-31/2020-09-18/14%3A37%3A00/Embedded%20Data%20Logger%20System%20Explorer.lvlib--File%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Throw Error if Invalid Path.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-31/2020-09-18/14%3A37%3A00/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Throw%20Error%20if%20Invalid%20Path.vi.png)
niphilj commented 3 years ago

Learned something new in Throw Error if Invalid Path.vi that you can leave the build path's base path input unwired. I had to try it to understand what the behavior was going to be.