ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 9 forks source link

Add support to enable and disable the custom device #32

Closed debryant closed 4 years ago

debryant commented 4 years ago

What does this Pull Request accomplish?

Allows the user to enable or disable the custom device.

image

Why should this Pull Request be merged?

Allows the user to enable or disable the custom device.

What testing has been done?

Built and manually tested the system explorer embedded menu behavior. (See picts above) Verified the engine is not called when the the embedded data logger is disabled.

Other

The vi "Enable or Disable" was renamed "Get Control Condition State". The enable/disable support added a new VI called "Enable or Disable", which introduced confusion with the existing "Enable or Disable" VI. I opted to rename the existing VI to something that better reflects its purpose.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger System Explorer.lvlib--Enable Disable.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-32/2020-09-24/17%3A56%3A39/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Enable%20Disable.vi.png)
Embedded Data Logger System Explorer.lvlib--File Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-32/2020-09-24/17%3A56%3A39/Embedded%20Data%20Logger%20System%20Explorer.lvlib--File%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Get Control Condition State.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-32/2020-09-24/17%3A56%3A39/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Get%20Control%20Condition%20State.vi.png)

The following VIs could not be diffed: