Add feature to append waveform properties to the channels if the acquisition is continuous

[oscarfonloz]

• [x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

This PR adds the capability to store waveform properties in log files that are continuous (if the user chooses to do so in the configuration).

Why should this Pull Request be merged?

See User Story 1278600 for the full spec.

What testing has been done?

Manual tests and review

[oscarfonloz]

FYI: My edits also adds a non-PR comment related to how the Async communicates to the RT Driver VI, since it took quite some time for us to understand it and I think it's worth capturing in the diagram. I also cleaned up the VIs I edited to implement the feature, but I did not change behavior/functions used (in case you see things moved around in the Diff)

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Append Waveform Properties to TDMS Channels.vi.png


Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png


Embedded Data Logger Engine.lvlib--Flush Close Archive File.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png


Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png


Embedded Data Logger Engine.lvlib--Process Falling Edge Trigger.vi.png


Embedded Data Logger Engine.lvlib--Sample File Data.vi.png


Embedded Data Logger Engine.lvlib--Update Logging Status.vi.png


Embedded Data Logger Shared.lvlib--Constants.vi.png


Embedded Data Logger System Explorer.lvlib--File Page.vi.png


[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Append Waveform Properties to TDMS Channels.vi.png


Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png


Embedded Data Logger Engine.lvlib--Flush Close Archive File.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png


Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png


Embedded Data Logger Engine.lvlib--Process Falling Edge Trigger.vi.png


Embedded Data Logger Engine.lvlib--Sample File Data.vi.png


Embedded Data Logger Engine.lvlib--Update Logging Status.vi.png


Embedded Data Logger Shared.lvlib--Constants.vi.png


Embedded Data Logger System Explorer.lvlib--File Page.vi.png


[rtzoeller]

@oscarfonloz it looks like Sample File Data.vi still has an action item?

There is a typo in the new control name on the file page (should be continuous), and the control description is wrong.

I still need to do some functional testing, but that will be a slow process due to power outages at my house.

[oscarfonloz]

@oscarfonloz it looks like Sample File Data.vi still has an action item?

Good catch! I did implement the functionality there, just forgot to remove the comment.

There is a typo in the new control name on the file page (should be continuous), and the control description is wrong.

Thanks! It's a tricky word! haha

I still need to do some functional testing, but that will be a slow process due to power outages at my house.

I planned to do the documentation in a later PR, but since we're already here, I submitted a tip strip and description that we can change later.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Append Waveform Properties to TDMS Channels.vi.png


Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png


Embedded Data Logger Engine.lvlib--Flush Close Archive File.vi.png


Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png


Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png


Embedded Data Logger Engine.lvlib--Process Falling Edge Trigger.vi.png


Embedded Data Logger Engine.lvlib--Sample File Data.vi.png


Embedded Data Logger Engine.lvlib--Update Logging Status.vi.png


Embedded Data Logger Shared.lvlib--Constants.vi.png


Embedded Data Logger System Explorer.lvlib--File Page.vi.png