ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 10 forks source link

Add a Channel Group Decimation channel #49

Closed debryant closed 2 years ago

debryant commented 2 years ago

What does this Pull Request accomplish?

Move the Decimation property from the Channel Group page to be a channel so that it can be programmatically changed from a test.

Why should this Pull Request be merged?

This is a feature request from IES who has the following use cases:

Use case: Some tests are 20 minutes some tests are 3 days some tests are 3 months. Want to adjust the decimation rate when starting a test. However the customer does not want to interface with the system definition file. They want a restricted access model where only dev engineers can make changes and technicians have different access levels and users can just run. So a configuration file loaded onto the system ingested by TestStand can configure the system correctly.

Use case: We want to have a set of standard log configurations (groups of channels to record) that can be configured per test without having to deploy. So, not programmatic change, VeriStand channel that can be set live. NOTE: Change would only apply before a log was started.

What testing has been done?

Unit tests have been run, and a new unit test created for this feature.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Commands Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Commands%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-09/09%3A51%3A18/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
rtzoeller commented 2 years ago

I've not tested the new deployed functionality yet, but the overall approach is about what I was expecting! I do have a few questions and some feedback I'd like to see addressed.

Nitpicks

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Commands Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Commands%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-09-17/09%3A10%3A25/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
debryant commented 2 years ago

Asynchronous Logging Loop.vi: Why the difference in behavior between "Open File" and "Open File then Log Data"? In what cases are the difference code-paths used? I'm not yet convinced that this will do the right thing in all cases.

“Open File then Log Data” is used when in the middle of a logging session and we are spanning files. Basically we have been given more data to log but it is time to close the current file and open the next in the set of spanned data files. In this case, we don't want to change the decimation value. “Open File” is used when the user has explicitly commanded to open a file. We are not in the midst of a data logging session. A new decimation value should be used/applied.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/15%3A35%3A20/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-07/18%3A05%3A24/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Assert Log File Is Valid.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Assert%20Log%20File%20Is%20Valid.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Perform Decimation Test.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Perform%20Decimation%20Test.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File%20Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-08/09%3A37%3A53/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File.vi.png)
rtzoeller commented 2 years ago

Can you replace the use of the Time Delay express VI in Perform Decimation Test.vi with DelayDataFlow.vim from the testing tools repo? That malleable skips the delay if an error has occurred, which will help this test fail faster.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Assert Log File Is Valid.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Assert%20Log%20File%20Is%20Valid.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Perform Decimation Test.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Perform%20Decimation%20Test.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File%20Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-12/11%3A04%3A43/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File.vi.png)
rtzoeller commented 2 years ago

Apologies for the scattered review feedback, but I just noticed that Channel Groups Page.vi provides a way to set the decimation which needs to be updated (along with Refresh Groups Table.vi). This VI wasn't modified in the PR, which is why I missed it.

buckd commented 2 years ago

I don't have any feedback other than what @rtzoeller has already provided. Ryan has the gating review.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Assert Log File Is Valid.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Assert%20Log%20File%20Is%20Valid.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Perform Decimation Test.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Perform%20Decimation%20Test.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File%20Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A16%3A46/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Groups Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Groups%20Table.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Assert Log File Is Valid.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Assert%20Log%20File%20Is%20Valid.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Perform Decimation Test.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Perform%20Decimation%20Test.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File%20Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-15/14%3A46%3A32/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File.vi.png)
rtzoeller commented 2 years ago

@debryant I am not seeing the decimation channels behave as expected in all cases.

Here is a reproducing project.

Steps:

  1. Deploy.
  2. Set "Log Trigger" to 0.
  3. Set "Log Command" to "Close File".
  4. View the archived log file (C:\log-archive) in DIAdem. The first channel group appears to correctly have a decimation of 10, and the second has a decimation of 1.
  5. Change the decimation channel value for Channel Group 1 to 1. My expectation is that the values logged for both groups should now be identical.
  6. Set "Log Command" to "Open File".
  7. Set "Log Trigger" to 1.
  8. Wait a bit.
  9. Set "Log Trigger" to 0.
  10. Set "Log Command" to "Close File".
  11. View the archived log file (C:\log-archive) in DIAdem. The first channel group appears to incorrectly have a decimation of 10. I would have expected it to be 1.

Am I misunderstanding when the decimation should be applied?


The UI changes, including setting the values, look correct.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Groups Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Groups%20Table.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Assert Log File Is Valid.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Assert%20Log%20File%20Is%20Valid.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Perform Decimation Test.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Perform%20Decimation%20Test.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File%20Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-20/13%3A04%3A56/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Groups Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Groups%20Table.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Assert Log File Is Valid.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Assert%20Log%20File%20Is%20Valid.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Perform Decimation Test.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Perform%20Decimation%20Test.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File%20Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-21/15%3A39%3A51/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Engine.lvlib--Asynchronous Logging Loop.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Engine.lvlib--Asynchronous%20Logging%20Loop.vi.png)
Embedded Data Logger Engine.lvlib--Get Data Log File Settings.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Engine.lvlib--Get%20Data%20Log%20File%20Settings.vi.png)
Embedded Data Logger Engine.lvlib--Initialize Logging Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Engine.lvlib--Initialize%20Logging%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Read Channel Groups Decimation Values.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Channel%20Groups%20Decimation%20Values.vi.png)
Embedded Data Logger Engine.lvlib--Read Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Engine.lvlib--Read%20Decimation%20Channel.vi.png)
Embedded Data Logger Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Embedded Data Logger Engine.lvlib--Sample File Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Engine.lvlib--Sample%20File%20Data.vi.png)
Embedded Data Logger Engine.lvlib--Set dts in Channel Groups.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Engine.lvlib--Set%20dts%20in%20Channel%20Groups.vi.png)
Embedded Data Logger Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Shared.lvlib--Constants.vi.png)
Embedded Data Logger System Explorer.lvlib--ActionVIOnLoad.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--ActionVIOnLoad.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Decimation Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Decimation%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Initialize Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Initialize%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger System Explorer.lvlib--Mutate Channel Group Commands.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mutate%20Channel%20Group%20Commands.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Groups Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Groups%20Table.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Assert Log File Is Valid.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Assert%20Log%20File%20Is%20Valid.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Decimation Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Decimation%20Channel.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Log Command.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Log%20Command.vi.png)
Embedded Data Logger Windows System Tests.lvclass--Perform Decimation Test (Enable Logging Then Open File).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Perform%20Decimation%20Test%20(Enable%20Logging%20Then%20Open%20File).vi.png)
Embedded Data Logger Windows System Tests.lvclass--Perform Decimation Test (Open File Then Enable Logging).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--Perform%20Decimation%20Test%20(Open%20File%20Then%20Enable%20Logging).vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log Archive.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20Archive.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File Decimation Channel (Enable Logging Then Open File).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File%20Decimation%20Channel%20(Enable%20Logging%20Then%20Open%20File).vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File Decimation Channel (Open File Then Enable Logging).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File%20Decimation%20Channel%20(Open%20File%20Then%20Enable%20Logging).vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20File.vi.png)
Embedded Data Logger Windows System Tests.lvclass--test Log Span Time.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-49/2021-10-22/17%3A14%3A40/Embedded%20Data%20Logger%20Windows%20System%20Tests.lvclass--test%20Log%20Span%20Time.vi.png)