ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 9 forks source link

Extract scripting API for configuring channel group page #53

Closed rtzoeller closed 2 years ago

rtzoeller commented 2 years ago

What does this Pull Request accomplish?

Extract an unpolished API for manipulating the system definition, mostly limited in scope to the settings on the channel group page.

Why should this Pull Request be merged?

This is a continuation on the work done in #52.

What testing has been done?

Hand testing of the custom device in VeriStand. Unit tests pass.

rtzoeller commented 2 years ago

@buckd after this, the following work is left:

My hope is that they can continue to be medium-small PRs like this one, and that I'll be able to get multiple of them up concurrently.

Most of the hard work is done.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Scripting.lvlib--Add Channel Group.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20Scripting.lvlib--Add%20Channel%20Group.vi.png)
Embedded Data Logger Scripting.lvlib--Add Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20Scripting.lvlib--Add%20Log%20File.vi.png)
Embedded Data Logger Scripting.lvlib--Get Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20Scripting.lvlib--Get%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger Scripting.lvlib--Get Channel Group Decimation.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20Scripting.lvlib--Get%20Channel%20Group%20Decimation.vi.png)
Embedded Data Logger Scripting.lvlib--Set Channel Group Channel Names.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20Scripting.lvlib--Set%20Channel%20Group%20Channel%20Names.vi.png)
Embedded Data Logger Scripting.lvlib--Set Channel Group Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20Scripting.lvlib--Set%20Channel%20Group%20Channels.vi.png)
Embedded Data Logger Scripting.lvlib--Set Channel Group Decimation.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20Scripting.lvlib--Set%20Channel%20Group%20Decimation.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Log File RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Log%20File%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Log File with INI Defaults.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Log%20File%20with%20INI%20Defaults.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Main Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Main%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Refresh Groups Table.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-53/2021-10-28/17%3A50%3A27/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Refresh%20Groups%20Table.vi.png)
rtzoeller commented 2 years ago

@buckd I don't recall. I had noticed that as well, but I can't remember the behavior for setting that flag to true vs. calling Highlight Node in System Explorer explicitly. If it is an issue, we should be able to hoist those calls out of the API easily.