ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 10 forks source link

Support navigating log files and setting the default trigger values #57

Closed rtzoeller closed 2 years ago

rtzoeller commented 2 years ago

What does this Pull Request accomplish?

Add support for navigating existing log files in the system definition, and setting the default log trigger value.

Why should this Pull Request be merged?

These are required features for the scripting API.

What testing has been done?

Introduced a new unit test which calls all the log file property accessors to validate they work outside VeriStand.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Scripting Unit Tests.lvclass--test Add Find Remove Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/11%3A04%3A59/Embedded%20Data%20Logger%20Scripting%20Unit%20Tests.lvclass--test%20Add%20Find%20Remove%20Log%20File.vi.png)
Embedded Data Logger Scripting Unit Tests.lvclass--test Set and Get All Log File Properties.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/11%3A04%3A59/Embedded%20Data%20Logger%20Scripting%20Unit%20Tests.lvclass--test%20Set%20and%20Get%20All%20Log%20File%20Properties.vi.png)
Embedded Data Logger Scripting.lvlib--Find All Log Files.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/11%3A04%3A59/Embedded%20Data%20Logger%20Scripting.lvlib--Find%20All%20Log%20Files.vi.png)
Embedded Data Logger Scripting.lvlib--Find Log File by Name.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/11%3A04%3A59/Embedded%20Data%20Logger%20Scripting.lvlib--Find%20Log%20File%20by%20Name.vi.png)
Embedded Data Logger Scripting.lvlib--Get Log Trigger Default Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/11%3A04%3A59/Embedded%20Data%20Logger%20Scripting.lvlib--Get%20Log%20Trigger%20Default%20Value.vi.png)
Embedded Data Logger Scripting.lvlib--Remove Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/11%3A04%3A59/Embedded%20Data%20Logger%20Scripting.lvlib--Remove%20Log%20File.vi.png)
Embedded Data Logger Scripting.lvlib--Set Log Trigger Default Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/11%3A04%3A59/Embedded%20Data%20Logger%20Scripting.lvlib--Set%20Log%20Trigger%20Default%20Value.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Scripting Unit Tests.lvclass--test Add Find Remove Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/14%3A21%3A44/Embedded%20Data%20Logger%20Scripting%20Unit%20Tests.lvclass--test%20Add%20Find%20Remove%20Log%20File.vi.png)
Embedded Data Logger Scripting Unit Tests.lvclass--test Set and Get All Log File Properties.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/14%3A21%3A44/Embedded%20Data%20Logger%20Scripting%20Unit%20Tests.lvclass--test%20Set%20and%20Get%20All%20Log%20File%20Properties.vi.png)
Embedded Data Logger Scripting.lvlib--Find All Log Files.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/14%3A21%3A44/Embedded%20Data%20Logger%20Scripting.lvlib--Find%20All%20Log%20Files.vi.png)
Embedded Data Logger Scripting.lvlib--Find Log File by Name.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/14%3A21%3A44/Embedded%20Data%20Logger%20Scripting.lvlib--Find%20Log%20File%20by%20Name.vi.png)
Embedded Data Logger Scripting.lvlib--Get Log Trigger Default Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/14%3A21%3A44/Embedded%20Data%20Logger%20Scripting.lvlib--Get%20Log%20Trigger%20Default%20Value.vi.png)
Embedded Data Logger Scripting.lvlib--Remove Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/14%3A21%3A44/Embedded%20Data%20Logger%20Scripting.lvlib--Remove%20Log%20File.vi.png)
Embedded Data Logger Scripting.lvlib--Set Log Trigger Default Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/14%3A21%3A44/Embedded%20Data%20Logger%20Scripting.lvlib--Set%20Log%20Trigger%20Default%20Value.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Scripting Unit Tests.lvclass--test Add Find Remove Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/15%3A22%3A02/Embedded%20Data%20Logger%20Scripting%20Unit%20Tests.lvclass--test%20Add%20Find%20Remove%20Log%20File.vi.png)
Embedded Data Logger Scripting Unit Tests.lvclass--test Set and Get All Log File Properties.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/15%3A22%3A02/Embedded%20Data%20Logger%20Scripting%20Unit%20Tests.lvclass--test%20Set%20and%20Get%20All%20Log%20File%20Properties.vi.png)
Embedded Data Logger Scripting.lvlib--Find All Log Files.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/15%3A22%3A02/Embedded%20Data%20Logger%20Scripting.lvlib--Find%20All%20Log%20Files.vi.png)
Embedded Data Logger Scripting.lvlib--Find Log File by Name.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/15%3A22%3A02/Embedded%20Data%20Logger%20Scripting.lvlib--Find%20Log%20File%20by%20Name.vi.png)
Embedded Data Logger Scripting.lvlib--Get Log Trigger Default Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/15%3A22%3A02/Embedded%20Data%20Logger%20Scripting.lvlib--Get%20Log%20Trigger%20Default%20Value.vi.png)
Embedded Data Logger Scripting.lvlib--Remove Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/15%3A22%3A02/Embedded%20Data%20Logger%20Scripting.lvlib--Remove%20Log%20File.vi.png)
Embedded Data Logger Scripting.lvlib--Set Log Trigger Default Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-57/2021-11-01/15%3A22%3A02/Embedded%20Data%20Logger%20Scripting.lvlib--Set%20Log%20Trigger%20Default%20Value.vi.png)