search

ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 10 forks source link

Simplify adding a new channel group with scripting API #61

Closed rtzoeller closed 2 years ago

rtzoeller commented 2 years ago

What does this Pull Request accomplish?

Add Channel Group now takes in a reference to the log file, which simplifies calling it.

Why should this Pull Request be merged?

Change requested by @Karl-G1.

What testing has been done?

Ran unit tests, tested adding a channel group in system explorer.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Scripting System Tests.lvclass--test Deploy Scripted Custom Device with One Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-11/11%3A37%3A45/Embedded%20Data%20Logger%20Scripting%20System%20Tests.lvclass--test%20Deploy%20Scripted%20Custom%20Device%20with%20One%20Channel.vi.png)
Embedded Data Logger Scripting Unit Tests.lvclass--test Add Log File with Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-11/11%3A37%3A45/Embedded%20Data%20Logger%20Scripting%20Unit%20Tests.lvclass--test%20Add%20Log%20File%20with%20Channels.vi.png)
Embedded Data Logger Scripting.lvlib--Add Channel Group.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-11/11%3A37%3A45/Embedded%20Data%20Logger%20Scripting.lvlib--Add%20Channel%20Group.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-11/11%3A37%3A45/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-11/11%3A37%3A45/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Scripting System Tests.lvclass--test Deploy Scripted Custom Device with One Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-12/09%3A20%3A45/Embedded%20Data%20Logger%20Scripting%20System%20Tests.lvclass--test%20Deploy%20Scripted%20Custom%20Device%20with%20One%20Channel.vi.png)
Embedded Data Logger Scripting Unit Tests.lvclass--test Add Log File with Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-12/09%3A20%3A45/Embedded%20Data%20Logger%20Scripting%20Unit%20Tests.lvclass--test%20Add%20Log%20File%20with%20Channels.vi.png)
Embedded Data Logger Scripting.lvlib--Add Channel Group.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-12/09%3A20%3A45/Embedded%20Data%20Logger%20Scripting.lvlib--Add%20Channel%20Group.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-12/09%3A20%3A45/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-61/2021-11-12/09%3A20%3A45/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)