ni / niveristand-embedded-data-logger-custom-device

VeriStand embedded data logger custom device
MIT License
3 stars 10 forks source link

Only set "New" property in System Explorer #62

Closed rtzoeller closed 2 years ago

rtzoeller commented 2 years ago

What does this Pull Request accomplish?

Move some property creation to only occur when called from System Explorer.

Why should this Pull Request be merged?

The custom device creates a "New" property in some cases, to detect when to automatically select the name field on log file and channel group pages for the first load.

We should not create these properties when using the scripting API.

What testing has been done?

Ran unit tests, hand testing in System Explorer.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Embedded Data Logger Scripting.lvlib--Add Channel Group.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-62/2021-11-12/11%3A24%3A56/Embedded%20Data%20Logger%20Scripting.lvlib--Add%20Channel%20Group.vi.png)
Embedded Data Logger Scripting.lvlib--Add Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-62/2021-11-12/11%3A24%3A56/Embedded%20Data%20Logger%20Scripting.lvlib--Add%20Log%20File.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Channel Group RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-62/2021-11-12/11%3A24%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Channel%20Group%20RTM.vi.png)
Embedded Data Logger System Explorer.lvlib--Add Log File with INI Defaults.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-62/2021-11-12/11%3A24%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Add%20Log%20File%20with%20INI%20Defaults.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Group Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-62/2021-11-12/11%3A24%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Group%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Channel Groups Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-62/2021-11-12/11%3A24%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Channel%20Groups%20Page.vi.png)
Embedded Data Logger System Explorer.lvlib--Mark Item as New.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-embedded-data-logger-custom-device/PR-62/2021-11-12/11%3A24%3A56/Embedded%20Data%20Logger%20System%20Explorer.lvlib--Mark%20Item%20as%20New.vi.png)
rtzoeller commented 2 years ago

@buckd there were some weird cross linking issues in a previous change that had some VIs pointing to the scripting API in the built directory. This VI really wanted to be saved with the source location when I did a clean build, so I'd like to keep it.