ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Add counter pwm input mode #127

Closed rdecarreau closed 3 years ago

rdecarreau commented 3 years ago

What does this Pull Request accomplish?

Adds support for Counter PWM input mode.

Why should this Pull Request be merged?

To create modules which support this mode of input

What testing has been done?

Ran the vi tests locally, although those don't cover this new mode yet. I modified the 9422 locally to use the new CPI mode and that passed tests.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Convert CPI Module to Slot Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Convert%20CPI%20Module%20to%20Slot%20Configuration.vi.png)
Scan Engine Scripting.lvlib--Convert to CPI Module.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Convert%20to%20CPI%20Module.vi.png)
Scan Engine Scripting.lvlib--Counter PWM Input Mode.lvclass--Create Channel Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Counter%20PWM%20Input%20Mode.lvclass--Create%20Channel%20Array.vi.png)
Scan Engine Scripting.lvlib--Counter PWM Input Mode.lvclass--Create Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Counter%20PWM%20Input%20Mode.lvclass--Create%20Channel.vi.png)
Scan Engine Scripting.lvlib--Counter PWM Input Mode.lvclass--Create.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Counter%20PWM%20Input%20Mode.lvclass--Create.vi.png)
Scan Engine Scripting.lvlib--Counter PWM Input Mode.lvclass--Read Channel Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Counter%20PWM%20Input%20Mode.lvclass--Read%20Channel%20Array.vi.png)
Scan Engine Scripting.lvlib--Get Slot.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Get%20Slot.vi.png)
Scan Engine Scripting.lvlib--Module.lvclass--Read Counter PWM Input Module.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Module.lvclass--Read%20Counter%20PWM%20Input%20Module.vi.png)
Scan Engine Scripting.lvlib--PWM Input Channel.lvclass--Read PWM Input Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--PWM%20Input%20Channel.lvclass--Read%20PWM%20Input%20Channel.vi.png)
Scan Engine Scripting.lvlib--Set Slot.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-02/16%3A07%3A56/Scan%20Engine%20Scripting.lvlib--Set%20Slot.vi.png)
rtzoeller commented 3 years ago
rdecarreau commented 3 years ago

@rtzoeller I named it this way because this is "Counter" mode with "PWM" measurement mode. I don't think we had a convention for this before.

rdecarreau commented 3 years ago

@rtzoeller Updated the naming and acronyms, updated to use typedefs (controls copied from the SD Modules class).

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Convert CI PWM Module to Slot Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Convert%20CI%20PWM%20Module%20to%20Slot%20Configuration.vi.png)
Scan Engine Scripting.lvlib--Convert to CI PWM Module.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Convert%20to%20CI%20PWM%20Module.vi.png)
Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create Channel Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Counter%20Input%20PWM%20Mode.lvclass--Create%20Channel%20Array.vi.png)
Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Counter%20Input%20PWM%20Mode.lvclass--Create%20Channel.vi.png)
Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Counter%20Input%20PWM%20Mode.lvclass--Create.vi.png)
Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Read Channel Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Counter%20Input%20PWM%20Mode.lvclass--Read%20Channel%20Array.vi.png)
Scan Engine Scripting.lvlib--Get Slot.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Get%20Slot.vi.png)
Scan Engine Scripting.lvlib--Module.lvclass--Read Counter Input PWM Module.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Module.lvclass--Read%20Counter%20Input%20PWM%20Module.vi.png)
Scan Engine Scripting.lvlib--PWM Input Channel.lvclass--Read PWM Input Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--PWM%20Input%20Channel.lvclass--Read%20PWM%20Input%20Channel.vi.png)
Scan Engine Scripting.lvlib--Set Slot.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-03/18%3A44%3A08/Scan%20Engine%20Scripting.lvlib--Set%20Slot.vi.png)
rtzoeller commented 3 years ago

@rdecarreau it looks like CPI is still used in the icon for Read Counter Input PWM Module.vi.

rdecarreau commented 3 years ago

Removed CPI, good catch Sorted Get Slot cases (@oscarfonloz take note of this) Added controls.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Convert CI PWM Module to Slot Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Convert%20CI%20PWM%20Module%20to%20Slot%20Configuration.vi.png)
Scan Engine Scripting.lvlib--Convert to CI PWM Module.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Convert%20to%20CI%20PWM%20Module.vi.png)
Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create Channel Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Counter%20Input%20PWM%20Mode.lvclass--Create%20Channel%20Array.vi.png)
Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Counter%20Input%20PWM%20Mode.lvclass--Create%20Channel.vi.png)
Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Counter%20Input%20PWM%20Mode.lvclass--Create.vi.png)
Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Read Channel Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Counter%20Input%20PWM%20Mode.lvclass--Read%20Channel%20Array.vi.png)
Scan Engine Scripting.lvlib--Get Slot.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Get%20Slot.vi.png)
Scan Engine Scripting.lvlib--Module.lvclass--Read Counter Input PWM Module.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Module.lvclass--Read%20Counter%20Input%20PWM%20Module.vi.png)
Scan Engine Scripting.lvlib--PWM Input Channel.lvclass--Read PWM Input Channel.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--PWM%20Input%20Channel.lvclass--Read%20PWM%20Input%20Channel.vi.png)
Scan Engine Scripting.lvlib--Set Slot.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-127/2020-12-04/14%3A47%3A03/Scan%20Engine%20Scripting.lvlib--Set%20Slot.vi.png)