Add counter pwm input mode

[rdecarreau]

• [x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Adds support for Counter PWM input mode.

Why should this Pull Request be merged?

To create modules which support this mode of input

What testing has been done?

Ran the vi tests locally, although those don't cover this new mode yet. I modified the 9422 locally to use the new CPI mode and that passed tests.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Convert CPI Module to Slot Configuration.vi.png


Scan Engine Scripting.lvlib--Convert to CPI Module.vi.png


Scan Engine Scripting.lvlib--Counter PWM Input Mode.lvclass--Create Channel Array.vi.png


Scan Engine Scripting.lvlib--Counter PWM Input Mode.lvclass--Create Channel.vi.png


Scan Engine Scripting.lvlib--Counter PWM Input Mode.lvclass--Create.vi.png


Scan Engine Scripting.lvlib--Counter PWM Input Mode.lvclass--Read Channel Array.vi.png


Scan Engine Scripting.lvlib--Get Slot.vi.png


Scan Engine Scripting.lvlib--Module.lvclass--Read Counter PWM Input Module.vi.png


Scan Engine Scripting.lvlib--PWM Input Channel.lvclass--Read PWM Input Channel.vi.png


Scan Engine Scripting.lvlib--Set Slot.vi.png


[rtzoeller]

• [x] I'm a bit confused by naming. The existing PWM output mode is called PWM Mode, and this one is called Counter PWM Input Mode. Should the existing class be named Counter PWM Output Mode, or am I missing something?

• [x] The nested acronyms in CPI bug me a bit; I would not immediately assume that CPI was related to PWM, and it looks like it would conflict with the acronym for period measurements on specialty digital modules. I'm wondering if there's a clearer short-hand we can use.

• [x] In Convert CPI Module to Slot Configuration.vi, I'd prefer if we used the ring types rather than numeric literals. Unfortunately they aren't typedef'd, so you need to copy it, but IMO it makes the code much clearer.

[rdecarreau]

@rtzoeller I named it this way because this is "Counter" mode with "PWM" measurement mode. I don't think we had a convention for this before.

[rdecarreau]

@rtzoeller Updated the naming and acronyms, updated to use typedefs (controls copied from the SD Modules class).

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Convert CI PWM Module to Slot Configuration.vi.png


Scan Engine Scripting.lvlib--Convert to CI PWM Module.vi.png


Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create Channel Array.vi.png


Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create Channel.vi.png


Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create.vi.png


Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Read Channel Array.vi.png


Scan Engine Scripting.lvlib--Get Slot.vi.png


Scan Engine Scripting.lvlib--Module.lvclass--Read Counter Input PWM Module.vi.png


Scan Engine Scripting.lvlib--PWM Input Channel.lvclass--Read PWM Input Channel.vi.png


Scan Engine Scripting.lvlib--Set Slot.vi.png


[rtzoeller]

@rdecarreau it looks like CPI is still used in the icon for Read Counter Input PWM Module.vi.

[rdecarreau]

Removed CPI, good catch Sorted Get Slot cases (@oscarfonloz take note of this) Added controls.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Convert CI PWM Module to Slot Configuration.vi.png


Scan Engine Scripting.lvlib--Convert to CI PWM Module.vi.png


Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create Channel Array.vi.png


Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create Channel.vi.png


Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Create.vi.png


Scan Engine Scripting.lvlib--Counter Input PWM Mode.lvclass--Read Channel Array.vi.png


Scan Engine Scripting.lvlib--Get Slot.vi.png


Scan Engine Scripting.lvlib--Module.lvclass--Read Counter Input PWM Module.vi.png


Scan Engine Scripting.lvlib--PWM Input Channel.lvclass--Read PWM Input Channel.vi.png


Scan Engine Scripting.lvlib--Set Slot.vi.png