Closed oscarfonloz closed 3 years ago
Please update the PR title.
Please update the PR title.
Thanks! Done 👍🏻
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
We seem to be using two different patterns for calling Get Slot.vim
.
In the new test, we are passing a new class constant to specify the type:
In some of the existing tests, we pass the existing class wire:
I have a slight preference for the first approach, as the second approach will pass if Get Slot.vim
just returns the input. Can you update just the tests which are already modified by this PR to use this approach throughout?
Why is Allow Polymorphic VI to Adapt to Data Type
being re-enabled for Create Counter Driven Output Module.vi
?
We seem to be using two different patterns for calling
Get Slot.vim
.In the new test, we are passing a new class constant to specify the type In some of the existing tests, we pass the existing class wire
I have a slight preference for the first approach, as the second approach will pass if
Get Slot.vim
just returns the input. Can you update just the tests which are already modified by this PR to use this approach throughout?
I agree, I will change those in this PR and ensure they pass.
Why is
Allow Polymorphic VI to Adapt to Data Type
being re-enabled forCreate Counter Driven Output Module.vi
?
Because I'm dumb and forgot to remove that VI, too 😂 Thank you!
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
:warning: PR 143 must be merged first into main.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
Expands our test suite and ensures we do not break functionality as we keep expanding the scripting API
What testing has been done?
Ensured all tests run and added more