search

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Stop pulling an action VI into scripting API #163

Closed rtzoeller closed 3 years ago

rtzoeller commented 3 years ago

What does this Pull Request accomplish?

Extract some deletion logic out of the custom device On Delete action VI.

Why should this Pull Request be merged?

We don't want to ship an Action VI as part of the scripting API dependencies; we should only be pulling in helper methods.

What testing has been done?

None; this is a straightforward refactor and I am relying on the build process to validate.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Custom Device.lvlib--Main - On Delete.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-163/2021-02-03/16%3A45%3A25/Scan%20Engine%20Custom%20Device.lvlib--Main%20-%20On%20Delete.vi.png)
Scan Engine Custom Device.lvlib--Update Controller Settings on Delete.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-163/2021-02-03/16%3A45%3A25/Scan%20Engine%20Custom%20Device.lvlib--Update%20Controller%20Settings%20on%20Delete.vi.png)
Scan Engine Scripting.lvlib--Remove Scan Engine Custom Device.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-163/2021-02-03/16%3A45%3A25/Scan%20Engine%20Scripting.lvlib--Remove%20Scan%20Engine%20Custom%20Device.vi.png)