search

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Fix EtherCAT system tests failing with 21.0+ drivers #173

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Hard-code some parameters in the ECAT system tests to avoid calling Find Slave Path.vi which breaks deployment with latest drivers.

Essentially, calling Find Slave Path.vi in both tests causes the deployment to fail. This works in older versions of the driver, and it works if you call the VI, close LabVIEW, then re-open and deploy. However, the same application instance shows the error every time.

(And yes, I could parameterize the new constants. However, I chose not to for now.)

Why should this Pull Request be merged?

Fix two tests that fail with driver versions 21.0+

What testing has been done?

Hand-copied the new files to the ATS and ran the tests successfully on an event where they previously failed.

image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO FPGA Mode Loop Back.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-173/2021-09-22/17%3A54%3A49/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20FPGA%20Mode%20Loop%20Back.vi.png)
Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO Scan Mode Loop Back.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-173/2021-09-22/17%3A54%3A49/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20Scan%20Mode%20Loop%20Back.vi.png)