ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand

MIT License

16 stars 22 forks source link

Fix EtherCAT FPGA system test #176

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

173 attempted to fix the EtherCAT system tests that have deployment issues as-written when used with the latest driver stack. The change implemented there works when a system definition is deployed to a 'dirty' controller (Scan Engine config has been deployed on it). However, on a freshly imaged controller, the call to download the FPGA bitfile fails.

To work around this behavior, this change first deploys the system definition file. This fails, but then allows the bitfile deployment to succeed.

Why should this Pull Request be merged?

Fixes broken system test that was not fixed by #173

What testing has been done?

Tested on a freshly imaged PXI controller. This also works by deleting the ECAT config (/var/local/natinst/deployfwk) and rebooting before deploying.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO FPGA Mode Loop Back.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-176/2021-10-04/17%3A33%3A35/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20FPGA%20Mode%20Loop%20Back.vi.png)