search

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Split Auto Detect scripting logic into two additional sub VIs #184

Closed Karl-G1 closed 3 years ago

Karl-G1 commented 3 years ago

What does this Pull Request accomplish?

Split System Explorer/Action VIs/Main - Auto Detect Modules.vi scripting logic into two additional sub VIs.

Why should this Pull Request be merged?

System Explorer/Action VIs/Main - Auto Detect Modules.vi is almost impossible to edit or review without scrolling sideways a lot. This will reduce pain when reviewing changes caused by removing IOV references from type defs.

What testing has been done?

None

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Main - Auto Detect Modules.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-184/2021-10-22/17%3A06%3A37/Main%20-%20Auto%20Detect%20Modules.vi.png)
SEECD System Explorer.lvlib--Add ECAT Slave from Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-184/2021-10-22/17%3A06%3A37/SEECD%20System%20Explorer.lvlib--Add%20ECAT%20Slave%20from%20Config.vi.png)
SEECD System Explorer.lvlib--Add Local Chassis from Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-184/2021-10-22/17%3A06%3A37/SEECD%20System%20Explorer.lvlib--Add%20Local%20Chassis%20from%20Config.vi.png)