Closed Karl-G1 closed 2 years ago
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Code changes look really good. Only minor feedback:
Error Cluster from Error Code
to create the error messages in the wrapper VIs. It gives more call stack information.Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
What does this Pull Request accomplish?
This PR builds applications out of the online hardware calls used in the System Explorer configuration code. It then calls them out-of-process by building CLI arguments and handling outputs and errors.
Major Changes
Revert to Scan Mode.vi
,Get HW Config.vi
,Check and Download Bitfile.vi
)Call ...
) to wrap the out-of-process calling of "Applications VI"Build Command Line Arguments.vi
Build Installed Folder Paths.vi
Applications
anddata
folders from Public DocsECAT FPGA OD FoE.vi
,ECAT Wipeback FoE.vi
,Host - Revert.vi
)data
folder now that base VI path is in an .exeMinor Changes
Why should this Pull Request be merged?
Enable building and running Action VIs with hardware configuration calls in LabVIEW 2021 32-bit to be called out-of-process from 64-bit runtime.
What testing has been done?
Tested calling the out-of-process calls with 64-bit VS.
All below testing done with ATS hardware using VS 2019 R3: