ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Call System Explorer hardware configuration VIs out of process #187

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

This PR builds applications out of the online hardware calls used in the System Explorer configuration code. It then calls them out-of-process by building CLI arguments and handling outputs and errors.

Major Changes

Minor Changes

Why should this Pull Request be merged?

Enable building and running Action VIs with hardware configuration calls in LabVIEW 2021 32-bit to be called out-of-process from 64-bit runtime.

What testing has been done?

Tested calling the out-of-process calls with 64-bit VS.

All below testing done with ATS hardware using VS 2019 R3:

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO FPGA Mode Loop Back.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20FPGA%20Mode%20Loop%20Back.vi.png)
Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO Scan Mode Loop Back.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20Scan%20Mode%20Loop%20Back.vi.png)
SEECD System Explorer.lvlib--Build Command Line Arguments.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Build%20Command%20Line%20Arguments.vi.png)
SEECD System Explorer.lvlib--Build Installed Folder Paths.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Build%20Installed%20Folder%20Paths.vi.png)
SEECD System Explorer.lvlib--Call Check and Download Bitfile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Call%20Check%20and%20Download%20Bitfile.vi.png)
SEECD System Explorer.lvlib--Call Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Call%20Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Call Revert to Scan Mode.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Call%20Revert%20to%20Scan%20Mode.vi.png)
SEECD System Explorer.lvlib--Check and Download Bitfile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Check%20and%20Download%20Bitfile.vi.png)
SEECD System Explorer.lvlib--ECAT FPGA OD FoE.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--ECAT%20FPGA%20OD%20FoE.vi.png)
SEECD System Explorer.lvlib--ECAT Wipeback FoE.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--ECAT%20Wipeback%20FoE.vi.png)
SEECD System Explorer.lvlib--FPGA - Download (ECAT).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--FPGA%20-%20Download%20(ECAT).vi.png)
SEECD System Explorer.lvlib--FPGA - Revert (ECAT).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--FPGA%20-%20Revert%20(ECAT).vi.png)
SEECD System Explorer.lvlib--Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Host - Find Path.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Host%20-%20Find%20Path.vi.png)
SEECD System Explorer.lvlib--Host - Revert.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Host%20-%20Revert.vi.png)
SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Main%20-%20Auto%20Detect%20Modules.vi.png)
SEECD System Explorer.lvlib--Revert to Scan Mode.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-02/18%3A46%3A36/SEECD%20System%20Explorer.lvlib--Revert%20to%20Scan%20Mode.vi.png)
rtzoeller commented 2 years ago

Code changes look really good. Only minor feedback:

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO FPGA Mode Loop Back.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20FPGA%20Mode%20Loop%20Back.vi.png)
Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO Scan Mode Loop Back.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20Scan%20Mode%20Loop%20Back.vi.png)
SEECD System Explorer.lvlib--Build Command Line Arguments.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Build%20Command%20Line%20Arguments.vi.png)
SEECD System Explorer.lvlib--Build Installed Folder Paths.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Build%20Installed%20Folder%20Paths.vi.png)
SEECD System Explorer.lvlib--Call Check and Download Bitfile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Call%20Check%20and%20Download%20Bitfile.vi.png)
SEECD System Explorer.lvlib--Call Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Call%20Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Call Revert to Scan Mode.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Call%20Revert%20to%20Scan%20Mode.vi.png)
SEECD System Explorer.lvlib--Check and Download Bitfile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Check%20and%20Download%20Bitfile.vi.png)
SEECD System Explorer.lvlib--ECAT FPGA OD FoE.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--ECAT%20FPGA%20OD%20FoE.vi.png)
SEECD System Explorer.lvlib--ECAT Generate OD For FPGA IOV.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--ECAT%20Generate%20OD%20For%20FPGA%20IOV.vi.png)
SEECD System Explorer.lvlib--ECAT Wipeback FoE.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--ECAT%20Wipeback%20FoE.vi.png)
SEECD System Explorer.lvlib--FPGA - Download (ECAT).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--FPGA%20-%20Download%20(ECAT).vi.png)
SEECD System Explorer.lvlib--FPGA - Revert (ECAT).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--FPGA%20-%20Revert%20(ECAT).vi.png)
SEECD System Explorer.lvlib--Generate Application Call Error.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Generate%20Application%20Call%20Error.vi.png)
SEECD System Explorer.lvlib--Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Host - Find Path.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Host%20-%20Find%20Path.vi.png)
SEECD System Explorer.lvlib--Host - Revert.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Host%20-%20Revert.vi.png)
SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Main%20-%20Auto%20Detect%20Modules.vi.png)
SEECD System Explorer.lvlib--Revert to Scan Mode.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-187/2021-11-03/10%3A08%3A28/SEECD%20System%20Explorer.lvlib--Revert%20to%20Scan%20Mode.vi.png)