search

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Move `Host - Refresh All` call inside `Get HW Config.vi` #188

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Move Host - Refresh All call inside Get HW Config.vi to call it out of process based on Boolean input. Update the 2 calling VIs (Auto Detect and Find Host) accordingly.

Why should this Pull Request be merged?

Fix issues when calling Auto Detect twice on 2021. The first call works, but the second crashes the LV process at Get Scan Engine Mode.vi

What testing has been done?

Tested on the ATS hardware configs with 2021.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Call Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-188/2021-11-05/12%3A15%3A46/SEECD%20System%20Explorer.lvlib--Call%20Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-188/2021-11-05/12%3A15%3A46/SEECD%20System%20Explorer.lvlib--Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Host - Find Path.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-188/2021-11-05/12%3A15%3A46/SEECD%20System%20Explorer.lvlib--Host%20-%20Find%20Path.vi.png)
SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-188/2021-11-05/12%3A15%3A46/SEECD%20System%20Explorer.lvlib--Main%20-%20Auto%20Detect%20Modules.vi.png)