Move dialog handling for out-of-process application to calling VIs

[Karl-G1]

• [x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Major Changes

• Modify VIs that had one-button dialogs and error handlers that would spawn dialogs
  • Replace dialogs with a string Message output that is passed out of the application
  • Bundle string output then flatten to avoid issues parsing the standard output
• Modify calling VIs to parse and display messages returned from application calls
  • Unflatten then unbundle message output
  • Call new sub VI Display Message Dialog.vi to show the returned messages when not empty

Minor Changes

• Change build specs for applications to run minimized and not let the user close
• Delete Host - ECAT Slaves write to XML-Log-File.vi
  • This created a file in My Documents that had no value other than debugging
  • Removed from disk, the library, and the calling VI (Host - Get Local and ECAT Masters.vi)
• Move sub VIs of the Applications into a Utilities folder
  • Saved all calling VIs, including two otherwise note modified (Target Communication/Support/ECAT FPGA OD FoE.vi and Target Communication/Support/ECAT Wipeback FoE.vi)

Why should this Pull Request be merged?

The primary change is to move dialog handling for out-of-process application to calling VIs. This was done for 1) correctness and 2) it was stalling out the automated tests because LabVIEW could not squash the one-button dialog launched when downloading a 9145 bitfile.

What testing has been done?

Lots of hand testing with VeriStand 2020 R6. ATS tests now pass without user intervention (with LabVIEW set to unattended mode).

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Build Command Line Arguments.vi.png


SEECD System Explorer.lvlib--Build Installed Folder Paths.vi.png


SEECD System Explorer.lvlib--Call Check and Download Bitfile.vi.png


SEECD System Explorer.lvlib--Call Get HW Config.vi.png


SEECD System Explorer.lvlib--Call Revert to Scan Mode.vi.png


SEECD System Explorer.lvlib--Check and Download Bitfile.vi.png


SEECD System Explorer.lvlib--Display Message Dialog.vi.png


SEECD System Explorer.lvlib--ECAT Download Error Handle.vi.png


SEECD System Explorer.lvlib--ECAT FPGA OD FoE.vi.png


SEECD System Explorer.lvlib--ECAT Wipeback FoE.vi.png


SEECD System Explorer.lvlib--Generate Application Call Error.vi.png


SEECD System Explorer.lvlib--Get HW Config.vi.png


SEECD System Explorer.lvlib--Host - Download.vi.png


SEECD System Explorer.lvlib--Host - Get HW Config.vi.png


SEECD System Explorer.lvlib--Host - Get Local and ECAT Masters With Retries.vi.png


SEECD System Explorer.lvlib--Host - Get Local and ECAT Masters.vi.png


SEECD System Explorer.lvlib--Host - Is Download Necessary.vi.png


SEECD System Explorer.lvlib--Host - Revert.vi.png


SEECD System Explorer.lvlib--Revert to Scan Mode.vi.png


[Karl-G1]

• [x] Did the FoE VIs change? If not, please revert them.

This was a consequence of moving the sub VIs of the Applications into a Utilities folder.