Closed Karl-G1 closed 2 years ago
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
ValidateDeviceProfile()
fails due to the .mxx file not existing. This error message would be a good opportunity to clarify which software needs to be installed.Get Webdav.vi
?Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
What does this Pull Request accomplish?
The end goal of this PR was to enable out-of-process calls inside of the "Manage 3rd Party ECAT Slaves" dialog. What it became was much more of a re-write and massive code re-organization, with some bug fixing along the way. Below is an attempt to describe the changes to aid review:
Major Changes
Main - Manages 3rd Party Slaves.vi
to the Action VIs folder in System Explorer libraryHost - Import ESI File.vi
_ValidateDeviceProfiles.vi
uses it to find niECATLVProvider.mxx_generateProfilePath.vi
uses it to build paths for ESI files on the hostImport ESI File.vi
andRead Target ESI Files.vi
Read ESI Files on RT Target.vi
Read ESI Files on RT Target.vi
Minor Changes
Get LabVIEW Directory.vi
ECAT_InternalSubVIs
from vi.lib to the custom device sourceECAT_InternalSubVIs
to show the SEECD banner to distinguish between those in vi.libECAT_InternalSubVIs
VIsWhy should this Pull Request be merged?
This PR should do the following:
What testing has been done?
Extensive hand testing in VeriStand 2020 R6 when configured to both Windows and Linux in the sysdef. I used a third-party ESI file to import to both the host and the target, as well as tested when the target's IP address was mis-configured.