ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Build combined package for 2021 32- and 64-bit builds #191

Closed buckd closed 2 years ago

buckd commented 2 years ago

What does this Pull Request accomplish?

Combines the output of the LabVIEW 2021 32- and 64-bit builds into a single .nipkg file.

Why should this Pull Request be merged?

This is needed to install everything required for 2021 with a single package as is done for 2019 and 2020.

What testing has been done?

PR build and inspected output of all packages. This change needs Build Tools 124 to be merged before it will produce results.

Karl-G1 commented 2 years ago

@buckd @rtzoeller I added the same package bitness settings to Scripting and Examples packages. Otherwise, the 64-bit build was producing the correct packages, then the slower 32-bit build was over-writing them with empty packages.

buckd commented 2 years ago

I added the same package bitness settings to Scripting and Examples packages. Otherwise, the 64-bit build was producing the correct packages, then the slower 32-bit build was over-writing them with empty packages.

@Karl-G1 I have already created an issue for this (https://github.com/ni/niveristand-custom-device-build-tools/issues/125) and should have a fix for it today.