Change Auto-Detect sequence to fix #166

Karl-G1 commented 2 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Check if modules are found before deleting the existing CD configuration
- Re-organize Main - Auto Detect Modules.vi to account for the new logic
- Add a helper VI Utility/Auto Detect/Confirm Hardware Found.vi to determine whether to continue
Add an error to throw when the returned list of hardware found on the target is empty

Why should this Pull Request be merged?

Fix #166
Fix an unfiled issue where not having Scan Engine installed on the RT target silently failed to find any installed modules

What testing has been done?

Locally built and tested against a cRIO with and without Scan Engine IPK installed.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD Shared.lvlib--String Constants.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/10%3A35%3A19/SEECD%20Shared.lvlib--String%20Constants.vi.png)

SEECD System Explorer.lvlib--Confirm Hardware Found.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/10%3A35%3A19/SEECD%20System%20Explorer.lvlib--Confirm%20Hardware%20Found.vi.png)

SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/10%3A35%3A19/SEECD%20System%20Explorer.lvlib--Main%20-%20Auto%20Detect%20Modules.vi.png)

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD Shared.lvlib--String Constants.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/11%3A34%3A56/SEECD%20Shared.lvlib--String%20Constants.vi.png)

SEECD System Explorer.lvlib--Confirm Hardware Found.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/11%3A34%3A56/SEECD%20System%20Explorer.lvlib--Confirm%20Hardware%20Found.vi.png)

SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/11%3A34%3A56/SEECD%20System%20Explorer.lvlib--Main%20-%20Auto%20Detect%20Modules.vi.png)

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD Shared.lvlib--String Constants.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/12%3A02%3A28/SEECD%20Shared.lvlib--String%20Constants.vi.png)

SEECD System Explorer.lvlib--Confirm Hardware Found.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/12%3A02%3A28/SEECD%20System%20Explorer.lvlib--Confirm%20Hardware%20Found.vi.png)

SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-192/2021-12-08/12%3A02%3A28/SEECD%20System%20Explorer.lvlib--Main%20-%20Auto%20Detect%20Modules.vi.png)

ni / niveristand-scan-engine-ethercat-custom-device