ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Generate CHM as part of build, simplify directory structure #194

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

This is some 'final' repo cleanup and reorganization to get this repo up to the standards of other custom device repos. Major changes include:

Why should this Pull Request be merged?

Quality of life improvements for the repo (especially anyone who ever touches the CHM again) Similar changes were started in a branch in 10/2020, but deferred due to scripting work at the time.

What testing has been done?

Locally built and tested the CHM is generated and copied to build location successfully. Will inspect the branch\PR builds to make sure the same files are pulled in.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Build CHM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-194/2021-12-09/09%3A50%3A50/Build%20CHM.vi.png)
Build VIs.lvlib--Call Build CHM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-194/2021-12-09/09%3A50%3A50/Build%20VIs.lvlib--Call%20Build%20CHM.vi.png)
Build VIs.lvlib--Pre-Build Action.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-194/2021-12-09/09%3A50%3A50/Build%20VIs.lvlib--Pre-Build%20Action.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Build CHM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-194/2021-12-09/10%3A24%3A16/Build%20CHM.vi.png)
Build VIs.lvlib--Call Build CHM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-194/2021-12-09/10%3A24%3A16/Build%20VIs.lvlib--Call%20Build%20CHM.vi.png)
Build VIs.lvlib--Pre-Build Action.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-194/2021-12-09/10%3A24%3A16/Build%20VIs.lvlib--Pre-Build%20Action.vi.png)