Add sub VI to locate CHM help file and page - Githubissues

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand

MIT License

16 stars 22 forks source link

Add sub VI to locate CHM help file and page #196

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Add a sub VI (stolen from Routing and Faulting) to load the CHM in each Page VI
Update each Page VI to use the new Load CHM Page.vi
Change output directory of built CHM to custom device root instead of \data

Why should this Pull Request be merged?

Fixes an issue introduced in #194 which changed the structure of the CHM (by accident) and consequently broke the ability to view CHM help in System Explorer
Simplify Page VIs when loading CHM

What testing has been done?

Manually built and tested changes in 2019

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Build VIs.lvlib--Call Build CHM.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/Build%20VIs.lvlib--Call%20Build%20CHM.vi.png)

SEECD System Explorer.lvlib--Load Help Page.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Load%20Help%20Page.vi.png)

SEECD System Explorer.lvlib--Scan Engine Custom FPGA Page - ECAT.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Scan%20Engine%20Custom%20FPGA%20Page%20-%20ECAT.vi.png)

SEECD System Explorer.lvlib--Scan Engine Custom FPGA Page - Local.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Scan%20Engine%20Custom%20FPGA%20Page%20-%20Local.vi.png)

SEECD System Explorer.lvlib--Scan Engine Custom Main IO Network Variables.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Scan%20Engine%20Custom%20Main%20IO%20Network%20Variables.vi.png)

SEECD System Explorer.lvlib--Scan Engine EtherCAT Generic Slave.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Scan%20Engine%20EtherCAT%20Generic%20Slave.vi.png)

SEECD System Explorer.lvlib--Scan Engine EtherCAT Master.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Scan%20Engine%20EtherCAT%20Master.vi.png)

SEECD System Explorer.lvlib--Scan Engine EtherCAT Slave.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Scan%20Engine%20EtherCAT%20Slave.vi.png)

SEECD System Explorer.lvlib--Scan Engine Local Chassis.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Scan%20Engine%20Local%20Chassis.vi.png)

SEECD System Explorer.lvlib--Scan Engine Main Page.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-196/2021-12-10/14%3A40%3A13/SEECD%20System%20Explorer.lvlib--Scan%20Engine%20Main%20Page.vi.png)