Enable hybrid mode deployment on Combo Chassis

[Karl-G1]

• [x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

• This PR makes a lot of changes with the overall goal of enabling better handling of hybrid mode deployment to combo chassis targets (CompactRIO with DAQmx). This fix is a lot more complicated than just changing the FPGA / Scan Interface mode setting on the controller page, as that property is necessary on first deployment of FPGA bitfiles.
• The primary change is to the logic in the ActionVIOnDownload. Previously, this was used to set all modules to either Scan Mode or FPGA Mode depending on the chassis configuration. Now, it uses a new property of each slot of the local chassis to determine which mode to assign. Mode is only assigned when the new chassis property Apply Module Mode is enabled.
• It also changes up the "Slot Configuration" dialog when using auto-detect modules on combo chassis targets. This was done to make working with the typedef used for the module mode easier, as well as to persist the module mode to the system definition to optionally use later.

Full list of changes:

• Add new property for slots Slot Programming Mode to persist the value of Custom Device Source/System Explorer/Type Defs/Slot Programming Mode.ctl.
  • Default is 'Don't Modify'.
  • Added Scripting API entry points for this VI
  • Added read/write of the property to the slot page
• Add new property Apply Module Mode to the local chassis.
  • Default is False.
  • Added read/write of the property to the local chassis page, but could also be added to the Scripting API.
• Modified the System Explorer/Type Defs/Slot Programming Mode.ctl typedef to have the default value of 0 be 'Don't Modify'. This made logic easier to handle when searching for the property and returning the default when not found.
• Large changes to System Explorer/Utility/Auto Detect/Programming Mode.vi and its sub VIs:
  • Create a fourth control in the typedef to display both the current and desired value
  • Update front panel control handling logic to not disable the 'Don't Modify' option
  • Wire out the desired slot configuration for use in the Auto-Detect scripting logic (System Explorer/Utility/Auto Detect/Add Local Chassis from Config.vi)
  • Wire out if the dialog box was cancelled.
• Update the Auto-Detect scripting logic (System Explorer/Utility/Auto Detect/Add Local Chassis from Config.vi)
  • Persist the module configuration to the sysdef if the dialog was used to read/set slot configuration during auto-detect
    • Allows users to deploy this configuration in the future by enabling the Apply Module Mode property on the chassis
  • Do not call the rest of the Auto-Detect logic if the Programming Mode VI/dialog was cancelled
    • This was awkward existing behavior that is no longer needed because the existing module mode is kept and displayed by default.
• Heavily refactor System Explorer/Action VIs/ActionVIOnDownload - Set Scan Rate.vi
  • Remove all of the unused debug prints
  • Only attempt to set module mode when the Apply Module Mode property is True. Previously, this was based off of the FPGA / Scan Interface mode setting.
• Add new unit test test Reading Slot Configuration.vi to validate reading the slot numbers and configuration from a system definition file

Why should this Pull Request be merged?

• Allow a combo chassis target to be configured in hybrid mode and deployed without workarounds
• Fixes #68 and #200

What testing has been done?

• Lots of manual testing so far, using the 903x and 904x targets in the automated test systems.
• I have added one unit test (primarily to simplify debugging the logic of reading the slot configuration on deployment).
• I have test assets for the cRIO-9045 target in the Eco ATS, but I have not yet written system tests to prove that deploying different modes will take effect.

[Karl-G1]

Admittedly the worst part of this (possibly too-large-to-review) PR is the logic in the Get Local Chassis Slots Configuration VI:

Because the custom devices uses 3 different GUIDs for slots (depending if they are empty, populated with an RSI module, or 'inactive') AND the slot number is only retrievable if there is an RSI module tied to a lot, it is difficult to retrieve the list of local slots and their properties in order.

The 'fix' I implemented is ugly: read the children of the local chassis, then retrieve the name for each, finding "SlotX" in the name to determine which ones are slots. This was in lieu of adding a Slot Number property to each, since the name is not configurable and this didn't modify how the slot section was added or stored. But if this logic is too flaky, it is on my radar to replace.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Get Local Chassis Apply Module Mode.vi.png


Scan Engine Scripting.lvlib--Set Local Chassis Apply Module Mode.vi.png


Scan Engine Unit Tests.lvclass--test Reading Slot Configuration.vi.png


SEECD Shared.lvlib--Property Strings.vi.png


SEECD System Explorer.lvlib--ActionVIOnDownload - Set Scan Rate.vi.png


SEECD System Explorer.lvlib--Add Local Chassis from Config.vi.png


SEECD System Explorer.lvlib--Align cRIO Programming Mode.vi.png


SEECD System Explorer.lvlib--Get Apply Module Mode.vi.png


SEECD System Explorer.lvlib--Get Local Chassis Slots Configuration.vi.png


SEECD System Explorer.lvlib--Initialize UI Elements.vi.png


SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png


SEECD System Explorer.lvlib--Programming Mode.vi.png


SEECD System Explorer.lvlib--Read Property.vi.png


SEECD System Explorer.lvlib--Scan Engine Local Chassis.vi.png


SEECD System Explorer.lvlib--Scan Engine Slot Page.vi.png


SEECD System Explorer.lvlib--Set Main FPGA Chassis Slots Programming Mode.vi.png


SEECD System Explorer.lvlib--Update Slots.vi.png


[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Get Local Chassis Apply Module Mode.vi.png


Scan Engine Scripting.lvlib--Set Local Chassis Apply Module Mode.vi.png


Scan Engine Unit Tests.lvclass--test Reading Slot Configuration.vi.png


SEECD Shared.lvlib--Property Strings.vi.png


SEECD System Explorer.lvlib--ActionVIOnDownload - Set Scan Rate.vi.png


SEECD System Explorer.lvlib--Add Local Chassis from Config.vi.png


SEECD System Explorer.lvlib--Align cRIO Programming Mode.vi.png


SEECD System Explorer.lvlib--Get Apply Module Mode.vi.png


SEECD System Explorer.lvlib--Get Local Chassis Slots Configuration.vi.png


SEECD System Explorer.lvlib--Initialize UI Elements.vi.png


SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png


SEECD System Explorer.lvlib--Programming Mode.vi.png


SEECD System Explorer.lvlib--Read Property.vi.png


SEECD System Explorer.lvlib--Scan Engine Local Chassis.vi.png


SEECD System Explorer.lvlib--Scan Engine Slot Page.vi.png


SEECD System Explorer.lvlib--Set Main FPGA Chassis Slots Programming Mode.vi.png


[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Get Local Chassis Apply Module Mode.vi.png


Scan Engine Scripting.lvlib--Set Local Chassis Apply Module Mode.vi.png


Scan Engine Unit Tests.lvclass--test Reading Slot Configuration.vi.png


SEECD Shared.lvlib--Property Strings.vi.png


SEECD System Explorer.lvlib--ActionVIOnDownload - Set Scan Rate.vi.png


SEECD System Explorer.lvlib--Add Local Chassis from Config.vi.png


SEECD System Explorer.lvlib--Align cRIO Programming Mode.vi.png


SEECD System Explorer.lvlib--Get Apply Module Mode.vi.png


SEECD System Explorer.lvlib--Get Local Chassis Slots Configuration.vi.png


SEECD System Explorer.lvlib--Initialize UI Elements.vi.png


SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png


SEECD System Explorer.lvlib--Programming Mode.vi.png


SEECD System Explorer.lvlib--Read Property.vi.png


SEECD System Explorer.lvlib--Scan Engine Local Chassis.vi.png


SEECD System Explorer.lvlib--Scan Engine Slot Page.vi.png


SEECD System Explorer.lvlib--Set Main FPGA Chassis Slots Programming Mode.vi.png


[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine Scripting.lvlib--Get Local Chassis Apply Module Mode.vi.png


Scan Engine Scripting.lvlib--Set Local Chassis Apply Module Mode.vi.png


Scan Engine Unit Tests.lvclass--test Reading Slot Configuration.vi.png


SEECD Shared.lvlib--Property Strings.vi.png


SEECD System Explorer.lvlib--ActionVIOnDownload - Set Scan Rate.vi.png


SEECD System Explorer.lvlib--Add Local Chassis from Config.vi.png


SEECD System Explorer.lvlib--Align cRIO Programming Mode.vi.png


SEECD System Explorer.lvlib--Get Apply Module Mode.vi.png


SEECD System Explorer.lvlib--Get Local Chassis Slots Configuration.vi.png


SEECD System Explorer.lvlib--Initialize UI Elements.vi.png


SEECD System Explorer.lvlib--Main - Auto Detect Modules.vi.png


SEECD System Explorer.lvlib--Programming Mode.vi.png


SEECD System Explorer.lvlib--Read Property.vi.png


SEECD System Explorer.lvlib--Scan Engine Local Chassis.vi.png


SEECD System Explorer.lvlib--Scan Engine Slot Page.vi.png


SEECD System Explorer.lvlib--Set Main FPGA Chassis Slots Programming Mode.vi.png