search

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Check if LV, LVRT, and ECAT are installed before launching ECAT dialog #210

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Check if LV, LVRT, and ECAT are installed before launching the "Manage 3rd-Party ECAT Slaves" dialog from the custom device main page. This was done by adding a sub VI to read the appropriate registry keys before launching the dialog (and all of the initialization logic that happens with it).

Throw an error if any components are missing: image

Why should this Pull Request be merged?

This issue came up in escalation 1924218. The existing behavior is confusing, as several different errors can be thrown (as seen in #209).

What testing has been done?

Tested on VMs with:

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Check Host Software Installed.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-210/2022-05-02/12%3A16%3A07/SEECD%20System%20Explorer.lvlib--Check%20Host%20Software%20Installed.vi.png)
SEECD System Explorer.lvlib--Main - Manages 3rd Party Slaves.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-210/2022-05-02/12%3A16%3A07/SEECD%20System%20Explorer.lvlib--Main%20-%20Manages%203rd%20Party%20Slaves.vi.png)