Fix PXI EtherCAT tests by removing hardcoded IP address - Githubissues

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand

MIT License

16 stars 22 forks source link

Fix PXI EtherCAT tests by removing hardcoded IP address #212

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Build the inputs to sub VIs used to load the 9145's bitfile from the hostname in the targets.ini file
Remove the restrictive timeouts for the loopback, since we are now polling with a 1sec timeout by default

Why should this Pull Request be merged?

These tests are currently failing because the system was moved to a new subnet (and new IP address). The Remote IO test was failing due to needing power cycled.

What testing has been done?

Executed the modified tests on the ATS after a VS2020r6_22.0 event.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Scan Engine EtherCAT System Tests.lvclass--Get Active Target Hostname.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-212/2022-06-21/15%3A16%3A06/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--Get%20Active%20Target%20Hostname.vi.png)

Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO FPGA Mode Loop Back.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-212/2022-06-21/15%3A16%3A06/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20FPGA%20Mode%20Loop%20Back.vi.png)

Scan Engine EtherCAT System Tests.lvclass--test 9401 DIO Scan Mode Loop Back.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-212/2022-06-21/15%3A16%3A06/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%209401%20DIO%20Scan%20Mode%20Loop%20Back.vi.png)

Scan Engine EtherCAT System Tests.lvclass--test Remote IO DIO Loop Back.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-212/2022-06-21/15%3A16%3A06/Scan%20Engine%20EtherCAT%20System%20Tests.lvclass--test%20Remote%20IO%20DIO%20Loop%20Back.vi.png)