search

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Ignore errors from `Refresh Modules` calls #215

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Ignore errors from Refresh Modules calls by default

Why should this Pull Request be merged?

With some third-party EtherCAT devices' ESI files on disk and connected to the RT target, the RT VI Refresh Modules returns an error. This prevents both Auto-Detect and deployment from succeeding, even though the variables were successfully returned from the target.

This should be a relatively harmless change, and it enables at least one particular EtherCAT device to successfully detect and deploy.

What testing has been done?

Hand-testing with VeriStand 2020 R6 using the 21.5 RT feed

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD Engine.lvlib--Get Master and Local Mod IOVs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-215/2022-08-22/17%3A09%3A34/SEECD%20Engine.lvlib--Get%20Master%20and%20Local%20Mod%20IOVs.vi.png)
SEECD System Explorer.lvlib--Host - Refresh All.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-215/2022-08-22/17%3A09%3A34/SEECD%20System%20Explorer.lvlib--Host%20-%20Refresh%20All.vi.png)