search

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Fix Auto-Detect Modules when used with VeriStand 2023 Q1 #233

Closed Karl-G1 closed 1 year ago

Karl-G1 commented 1 year ago

What does this Pull Request accomplish?

Add logic to the application calling code when calling Auto-Detect to copy the needed cRIO DLLs to the application\data directory before calling Get HW Data.exe.

Why should this Pull Request be merged?

Fixes #227

What testing has been done?

Currently hand-testing on a 2023 Q1 install.

niveristand-diff-bot commented 1 year ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Call Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-08/16%3A37%3A19/SEECD%20System%20Explorer.lvlib--Call%20Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Copy cRIO DLLs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-08/16%3A37%3A19/SEECD%20System%20Explorer.lvlib--Copy%20cRIO%20DLLs.vi.png)
SEECD System Explorer.lvlib--Delete Application Data Directory.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-08/16%3A37%3A19/SEECD%20System%20Explorer.lvlib--Delete%20Application%20Data%20Directory.vi.png)
niveristand-diff-bot commented 1 year ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Call Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-09/14%3A09%3A07/SEECD%20System%20Explorer.lvlib--Call%20Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Copy cRIO DLLs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-09/14%3A09%3A07/SEECD%20System%20Explorer.lvlib--Copy%20cRIO%20DLLs.vi.png)
SEECD System Explorer.lvlib--Delete Application Data Directory.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-09/14%3A09%3A07/SEECD%20System%20Explorer.lvlib--Delete%20Application%20Data%20Directory.vi.png)
SEECD System Explorer.lvlib--Get LVAddons Directory.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-09/14%3A09%3A07/SEECD%20System%20Explorer.lvlib--Get%20LVAddons%20Directory.vi.png)
niveristand-diff-bot commented 1 year ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Call Get HW Config.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-10/12%3A09%3A02/SEECD%20System%20Explorer.lvlib--Call%20Get%20HW%20Config.vi.png)
SEECD System Explorer.lvlib--Copy cRIO DLLs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-10/12%3A09%3A02/SEECD%20System%20Explorer.lvlib--Copy%20cRIO%20DLLs.vi.png)
SEECD System Explorer.lvlib--Delete Application Data Directory.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-10/12%3A09%3A02/SEECD%20System%20Explorer.lvlib--Delete%20Application%20Data%20Directory.vi.png)
SEECD System Explorer.lvlib--Get LVRTE Directory.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-233/2023-03-10/12%3A09%3A02/SEECD%20System%20Explorer.lvlib--Get%20LVRTE%20Directory.vi.png)