Renaming the nipkgs is needed to avoid confusion about which one is the released package now that we build them every time.
Additionally, the unused code might cause confusion in the future.
What testing has been done?
Check the outputs of the PR build and a build I ran manually:
What does this Pull Request accomplish?
This adds the renaming behavior that was implemented in https://github.com/ni/niveristand-custom-device-build-tools/pull/156 to the custom-packaging.yaml It also removes some unused code that was sitting around and had the potential to throw errors.
Why should this Pull Request be merged?
Renaming the nipkgs is needed to avoid confusion about which one is the released package now that we build them every time. Additionally, the unused code might cause confusion in the future.
What testing has been done?
Check the outputs of the PR build and a build I ran manually: