search

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Add x86 packaging and manifest.json #241

Closed papowerNI closed 1 year ago

papowerNI commented 1 year ago

What does this Pull Request accomplish?

Adds behavior outlined in https://github.com/ni/niveristand-custom-device-build-tools/pull/158 and https://github.com/ni/niveristand-custom-device-build-tools/pull/157

Why should this Pull Request be merged?

Scan engine has custom packaging needs and so it currently has a separate packaging that requires these edits to be made to it specifically.

What testing has been done?

Output of PR build.

Karl-G1 commented 1 year ago

The x86 packaging change looks good from the dev build. However, the manifest file logic will need to be called for each lvVersion to match the logic in https://github.com/ni/niveristand-custom-device-build-tools/pull/157. There it is called in the post-build step for each version, so a manifest.json file is placed in each installer directory.

I think it would be as straightforward as indenting to include the new task in this larger loop? https://github.com/ni/niveristand-scan-engine-ethercat-custom-device/blob/1653bdf23de071ddabc40006c83a162c436d2aa0/custom-packaging.yml#L15

papowerNI commented 1 year ago

The x86 packaging change looks good from the dev build. However, the manifest file logic will need to be called for each lvVersion to match the logic in ni/niveristand-custom-device-build-tools#157. There it is called in the post-build step for each version, so a manifest.json file is placed in each installer directory.

I think it would be as straightforward as indenting to include the new task in this larger loop?

https://github.com/ni/niveristand-scan-engine-ethercat-custom-device/blob/1653bdf23de071ddabc40006c83a162c436d2aa0/custom-packaging.yml#L15

Ah you're right, I just put it in the wrong level of the packaging. Good catch!