Fix EtherCAT Help dialog linking, manifest URL

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand

MIT License

16 stars 22 forks source link

Fix EtherCAT Help dialog linking, manifest URL #242

Closed Karl-G1 closed 1 year ago

Karl-G1 commented 1 year ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Change the file patch to the ECAT CHM launched from the "Manage..." dialog
Add ".git" to end of Git URL in manifest file

Why should this Pull Request be merged?

Fix a bug that snuck into #236
Fix manifest file URL formatting as in https://github.com/ni/niveristand-custom-device-build-tools/pull/159

What testing has been done?

Branch build tested with VeriStand 2023 Q1

niveristand-diff-bot commented 1 year ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Get ECAT File Paths.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-242/2023-03-17/18%3A04%3A15/SEECD%20System%20Explorer.lvlib--Get%20ECAT%20File%20Paths.vi.png)

niveristand-diff-bot commented 1 year ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Get ECAT File Paths.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-242/2023-03-18/18%3A04%3A08/SEECD%20System%20Explorer.lvlib--Get%20ECAT%20File%20Paths.vi.png)