Check if EtherCAT Driver is installed before calling into DLL - Githubissues

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand

MIT License

16 stars 22 forks source link

Check if EtherCAT Driver is installed before calling into DLL #244

Closed Karl-G1 closed 1 year ago

Karl-G1 commented 1 year ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Check the registry to see if any version of EtherCAT is installed before calling any of the out-of-process applications that call into the EtherCAT DLL. Return a more intelligible error if it is not installed:

Why should this Pull Request be merged?

Fixes #243

What testing has been done?

Tested the following actions across 3 different versions, with and without ECAT installed:

Auto Detect
Manage 3rd Party ECAT Slaves
ECAT NI 9145 Actions

Version	ECAT Installed	ECAT Not Installed
2020 R6	Pass	Pass
2021 R3	Pass	Pass
2023 Q1	Pass	Pass

niveristand-diff-bot commented 1 year ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Call Check and Download Bitfile.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-244/2023-03-20/13%3A59%3A04/SEECD%20System%20Explorer.lvlib--Call%20Check%20and%20Download%20Bitfile.vi.png)

SEECD System Explorer.lvlib--Call Get HW Config.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-244/2023-03-20/13%3A59%3A04/SEECD%20System%20Explorer.lvlib--Call%20Get%20HW%20Config.vi.png)

SEECD System Explorer.lvlib--Call Revert to Scan Mode.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-244/2023-03-20/13%3A59%3A04/SEECD%20System%20Explorer.lvlib--Call%20Revert%20to%20Scan%20Mode.vi.png)

SEECD System Explorer.lvlib--Check ECAT Installed.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-244/2023-03-20/13%3A59%3A04/SEECD%20System%20Explorer.lvlib--Check%20ECAT%20Installed.vi.png)

SEECD System Explorer.lvlib--Check Host Software Installed.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-scan-engine-ethercat-custom-device/PR-244/2023-03-20/13%3A59%3A04/SEECD%20System%20Explorer.lvlib--Check%20Host%20Software%20Installed.vi.png)