Do not substitute upstream errors in sub VI

ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand

MIT License

16 stars 22 forks source link

Do not substitute upstream errors in sub VI #262

Closed Karl-G1 closed 6 months ago

Karl-G1 commented 6 months ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Only check if ECAT driver is installed and throw specific error if no error is passed

Why should this Pull Request be merged?

Fix a bug where all EtherCAT 9145 configuration errors are replaced with the error added in https://github.com/ni/niveristand-scan-engine-ethercat-custom-device/pull/244

If any upstream error occurs, the resulting error is confusing.

What testing has been done?

Simple change, built locally

buckd commented 6 months ago

/AzurePipelines run

azure-pipelines[bot] commented 6 months ago

Azure Pipelines successfully started running 1 pipeline(s).

niveristand-diff-bot commented 6 months ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Check ECAT Installed.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/ni/niveristand-scan-engine-ethercat-custom-device/PR-262/2024-02-26/14%3A09%3A42/SEECD%20System%20Explorer.lvlib--Check%20ECAT%20Installed.vi.png)