ni / niveristand-scan-engine-ethercat-custom-device

Provides NI Scan Engine, EtherCAT and Remote IO support for NI VeriStand
MIT License
16 stars 22 forks source link

Fix Auto-Detect function for 3rd Party EtherCAT slave device. #265

Closed Raagul-s closed 3 months ago

Raagul-s commented 3 months ago

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Some 3rd Party EtherCAT slave device gives duplicate resource names, Which causes Auto Detect function to throw error at To More Specific Class in Get ECAT Variable Contents.vi. This PR should fix the error.

What testing has been done?

Tested the Custom Device build with the 3rd Party EtherCAT slave device.

niveristand-diff-bot commented 3 months ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD System Explorer.lvlib--Get ECAT Variable Contents.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/ni/niveristand-scan-engine-ethercat-custom-device/PR-265/2024-05-16/23%3A57%3A28/SEECD%20System%20Explorer.lvlib--Get%20ECAT%20Variable%20Contents.vi.png)
SEECD System Explorer.lvlib--Host - Get Slaves.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/ni/niveristand-scan-engine-ethercat-custom-device/PR-265/2024-05-16/23%3A57%3A28/SEECD%20System%20Explorer.lvlib--Host%20-%20Get%20Slaves.vi.png)