Consolidate API to decrease OS-specific coupling

ni / niveristand-synchronization-custom-device

Enables timing and synchronization using NI hardware in VeriStand

MIT License

2 stars 6 forks source link

Consolidate API to decrease OS-specific coupling #7

Closed rtzoeller closed 5 years ago

rtzoeller commented 6 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Removes channels that were PharLap specific.
Disables PharLap-specific code on other platforms.
Add support for 802.1AS (dependent on additional NI-Sync driver support).

Why should this Pull Request be merged?

Allows for deployment to some non-PharLap targets.
Adds support for 802.1AS synchronization protocol, which was not previously supported on PXI.

What testing has been done?

Hand testing:

Confirmed 802.1AS on non-PharLap target can act as both a master and slave
- Used an NI cRIO-9045 as the other endpoint; the controlling VI is here
Confirmed 1588 between PharLap and non-PharLap controllers works and that both can master

rtzoeller commented 6 years ago

Adding @jashnani to the review to keep him in the loop

csjall commented 6 years ago

My TimeSync property node is broken for Pharlap. What am I missing?

csjall commented 6 years ago

Since we have a known error code for disconnecting terminals, use Clear Error.vi to filter it out and let all other errors through.

tannerblair commented 6 years ago

@csjall

My TimeSync property node is broken for Pharlap. What am I missing?

If you look in the bottom-left corner, you can see that your context is Linux 64. If you click that and change it to Pharlap it should "unbreak".

csjall commented 6 years ago

D.R.Y.

The 6683 and 6683H cases are common across platforms.

csjall commented 6 years ago

@csjall

My TimeSync property node is broken for Pharlap. What am I missing?

If you look in the bottom-left corner, you can see that your context is Linux 64. If you click that and change it to Pharlap it should "unbreak".

That does not seem to be the issue. @rtzoeller thinks I may be missing the NI TimeSync 18.0.1 driver.

csjall commented 6 years ago

Update README to include 802.1AS support.