tests(DB) Add tests for database namespace.

ni / nixnet-python

NI-XNET Python API

https://nixnet.readthedocs.io/en/latest/

MIT License

25 stars 22 forks source link

tests(DB) Add tests for database namespace. #257

Closed d-bohls closed 6 years ago

d-bohls commented 6 years ago

Fixes #238

[x] This contribution adheres to CONTRIBUTING.md.
[x] New tests have been created for any new features or regression tests for bugfixes.
[x] tox successfully runs, including unit tests and style checks (see CONTRIBUTING.md).

d-bohls commented 6 years ago

I rebased this PR with the commit from #256 since:

It is required for these tests to pass
I'm assuming the other PR will go in first

I'll merge and push this PR as soon as the other PR goes in.

coveralls commented 6 years ago

Coverage remained the same at 67.708% when pulling 9bad9229f57faad78fcb06c2b8de7e41c62af01d on d-bohls:dbUnitTests into efe3f4eb299572f35917617cebb1ddfb151d87d0 on ni:master.

d-bohls commented 6 years ago

Integration test coverage went from 78% to 86%. I found I had a preference for integration tests since most methods and properties are layered wrappers around driver calls. I found a couple of issues/bugs from performing actual driver calls as opposed to just mocking in unit tests. There is definite room for improvement of unit testing.

d-bohls commented 6 years ago

Peeking over code coverage results for cluster, the biggest lacking source of I see are that the flexray properties have yet to be tested or removed. The DbCollection class is another low coverage percentage that should be evaluated.