search

niXman / binapi

Binance API C++ implementation
Apache License 2.0
252 stars 85 forks source link

types.cpp 1394-1398 my_trade_info_t::construct': must return a value #32

Closed alexpitek closed 3 years ago

alexpitek commented 3 years ago

Hi niXman! Encountered the following issue: error C4716: 'binapi::rest::my_trades_info_t my_trade_info_t::construct': must return a value

types.cpp lines 1394-1398 my_trades_info_t::my_trade_info_t my_trades_info_t::my_trade_info_t::construct(const flatjson::fjson &json) { assert(json.is_valid());

assert("unimplemented" == nullptr);

} Please, help to fix. For now I just commented this code.

Regards, Alexpitek.

niXman commented 3 years ago

hi,

fixed: https://github.com/niXman/binapi/commit/0d091c65f43323d19272c9be9342b34d31e943b3

please test and close.

alexpitek commented 3 years ago

Thank you.