niXman / mingw-builds

Scripts for building the 32 and 64-bit MinGW-W64 compilers for Windows
Other
286 stars 107 forks source link

build: use eval to allow for tilde expansion #625

Closed JohannesKauffmann closed 1 year ago

JohannesKauffmann commented 1 year ago

Paths with spaces don't work, however. Document this.

Fixes #618.

niXman commented 1 year ago

merged, thanks!

please close the relevant ticket too.

JohannesKauffmann commented 1 year ago

eeeee...

I'm not sure I've done it right, and also not sure it was a great idea to merge this without letting the CI pass..

Looking at the Github jobs, it seems I've done an oopsie.

niXman commented 1 year ago

I see =)

any ideas about a correct fix?

JohannesKauffmann commented 1 year ago

Not yet.

Maybe better to revert this first, in order not to break everyone.

niXman commented 1 year ago

ah, you already did it.

JohannesKauffmann commented 1 year ago

626 should fix it.