niXman / mingw-builds

Scripts for building the 32 and 64-bit MinGW-W64 compilers for Windows
Other
282 stars 107 forks source link

build: also reject invalid options when fetching #636

Closed JohannesKauffmann closed 1 year ago

JohannesKauffmann commented 1 year ago

This avoids fetching for a long time, and then realising that the options given are invalid.

niXman commented 1 year ago

im sorry, but I can't accept this PR because it will broke fetch-only mode.

JohannesKauffmann commented 1 year ago

Can you elaborate how it will break fetch mode? From my point of view, it doesn't make sense to try to fetch sources for a configuration that is invalid.

As it stands right now, an invalid options configuration is accepted when only fetching, but gets rejected when trying to build. So why not reject it in the first place?

niXman commented 1 year ago

ah, right! the architecture+exceptions+threads_model+CRT_type must always be checked!

sorry, approved.

JohannesKauffmann commented 1 year ago

Thank you!