search

niacdoial / blemd

BMD importer for blender (BDL format also partially supported)
GNU General Public License v3.0
31 stars 12 forks source link

Fix texture mirroring #54

Closed edbefee3-3888-462a-9411-741b7e9eb54e closed 2 years ago

edbefee3-3888-462a-9411-741b7e9eb54e commented 2 years ago

Fixes texture mirroring, compacts TexCoordMatrix, and adds '.' to the _bckPaths

edbefee3-3888-462a-9411-741b7e9eb54e commented 2 years ago

Sorry for the mess btw, i'm new to creating PRs

niacdoial commented 2 years ago

I'm… honestly impressed by the work you did. (including understanding code I wrote 4 years ago, that must not have been easy lol) Nice work, about all of this! The only thing I think could benefit from more tweaking? The part where you re-wrote a description : Maybe the entire string can benefit from being "If you choose to import animations, you can choose to chain them or put them in individual actions". Your correction is still better than the original "if yes" description. Other than that, it's ready to be merged!

edbefee3-3888-462a-9411-741b7e9eb54e commented 2 years ago

Sure, I'll just change all the descriptions and names to have capitalization, and maybe tweak a few of them to be a bit clearer

edbefee3-3888-462a-9411-741b7e9eb54e commented 2 years ago

and that code definitely is a mess to read

niacdoial commented 2 years ago

alright, looks good to me! should I merge it now, or are there other changes you want to put in this?

edbefee3-3888-462a-9411-741b7e9eb54e commented 2 years ago

I'd say merge

niacdoial commented 2 years ago

merged!