search

niahmiah / mongoose-uuid

uuid type for mongoose
21 stars 24 forks source link

update dependencies and remove node-uuid #15

Closed SavePointSam closed 5 years ago

SavePointSam commented 6 years ago

This update removes the usage of node-uuid as it has been deprecated in favor of uuid. However, uuid no longer has the method parse that is used by this library. There has been a re-publish of parse using a fork of the original node-uuid that strips out everything other than the parse and unparse methods called uuid-parse.

uuid generation was still being used for testing purposes, so uuid has been added as a devDependency and related references have been updated to the newer API.

There was also a security vulnerability present in the older version of istanbul being used by this project. Updating istanbul has patched this without any apparent regressions.

Closes #13.

MaerF0x0 commented 6 years ago

@niahmiah Any plans for getting this merged? Wanting to move forward with mongoose-uuid

niahmiah commented 6 years ago

I would merge it, but the tests fail.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+25.5%) to 97.727% when pulling dbc8f535ef918f739a9fbf62b4fdf809ca1dfbb3 on SavePointSam:issue-13_use-uuid into f347df4fe5f02fcc72c47bcb1371884bc77b6a73 on niahmiah:master.

SavePointSam commented 6 years ago

After double checking the tests I noticed that there was a few problem dependencies. I went and updated everything. I've also cleaned out a bunch of dead code and updated the tests. The only branch I wasn't sure how to cover came from the use of mongoose internals.

I know this is now a much larger change than was original posted, though it seemed valuable to remove all the duplicate / dead code.

stevegoossens commented 5 years ago

Can this be merged then?